-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Implement --ephemeral flag #81
Comments
When I was doing this in the python implementation I came up with the
|
What's the reasoning for using the first few instead of last 8? Now that I ask I'm guessing it's because the beginning part is more easily comparable by eye, like with git commit hashes. |
Yeah, it is related to Jason's comment here. |
PR #277 is ready for review 👍 |
When testing internal p2p network calls, we would like to be able to run multiple node instances simultaneously.
To avoid db folder collusion, we want to set unique db folder name for every node id.
As a default db folder, current implementation is using last 8 characters of base64 encoded
Enr
appended to the application name:https://github.com/carver/trin/blob/d99232fd43c8dd0ec055150f382546cbba747bef/trin-core/src/utils.rs#L58
It will be better, if we change this to append the first few characters (instead of last 8) of the as-displayed node-id to the application name.
The text was updated successfully, but these errors were encountered: