Implement --ephemeral CLI flag
#277
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hmrtn
changed the title
--ephemeral CLI flag--ephemeral CLI flag
hmrtn
force-pushed
the
ephemeral-flag
branch
2 times, most recently
from
6a0f961 to
5b4e10a
Compare
rustfmt rm target build added: newsfragment renamed trin data dirs and cargo fmt spelling comment: todo message cargo fmt
ogenev
requested changes
May 2, 2022
There was a problem hiding this comment.
Setting the cleanup handler inside json-rpc IPC exiter will not trigger if we use HTTP json-rpc transport.
For me, it makes more sense to create a general tokio exit handler function and set the cleanup handler right after we receive ctrl-c signal in tokio as described in this example: https://docs.rs/tokio/latest/tokio/signal/fn.ctrl_c.html#examples.
async fn handle_tokio_exit() {
tokio::signal::ctrl_c()
.await
.expect("failed to pause until ctrl-c");
cleanup_data_dir();
}Then we can use this function in src/main.rs, trin-history/src/main.rs and trin-state/src/main.rs to wait for ctr-c and cleanup the directories.
| @@ -86,6 +87,7 @@ fn set_ipc_cleanup_handlers(ipc_path: &str) { | |||
| if let Err(err) = fs::remove_file(&ipc_path) { | |||
| debug!("Ctrl-C: Skipped removing {} because: {}", ipc_path, err); | |||
| }; | |||
| cleanup_data_dir(); | |||
There was a problem hiding this comment.
This will not trigger if we initialize the node with HTTP json-rpc transport instead of IPC.
This was referenced Jun 28, 2022
Merged
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
This Fixes #81, implementing the
--ephemeralCLI flag.How was it fixed?
This was fixed by creating a mutable singleton vector that stores the session's data path on startup and utilizes it in
utils::db::cleanup_data_dir, which deletes the ephemeral directories on signal interruption (if the--ephemeralCLI flag is enabled).Trin's signal interruption is already being handled in the
service.rsviasetup_ipc_cleanup_handlers(), and can only be called once. In order to minimize the amount of changes, a call tocleanup_data_dir()has been added here.To-Do
lock()usage with mutable global variables