Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Modifies get_default_data_dir to take node id instead of enr #116

Merged
merged 4 commits into from
Sep 24, 2021

Conversation

mrferris
Copy link
Collaborator

Implements @ogenev's initial thoughts from #81.

Uses the first 8 characters of the Node ID's base 10 representation.
Any thoughts on whether we may want hex instead, or less than 8 characters?

@mrferris mrferris requested a review from ogenev September 23, 2021 14:13
@njgheorghita
Copy link
Collaborator

Personally, I'd prefer to see hex used here. Not a strong opinion, but we'd use hex to display the node id to terminal output, so it seems more consistent to also use it here.

@jacobkaufmann
Copy link
Collaborator

LGTM. I think @pipermerriam's comments about the --ephemeral flag in #81 can be addressed separately if desired.

@mrferris mrferris merged commit 2c9f277 into ethereum:master Sep 24, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants