Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix outer derivative by replacing cwiseproduct with explicit matvec. #95

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pbrakel
Copy link

@pbrakel pbrakel commented Apr 7, 2022

Thanks for writing such a nice piece of software!

There seems to be a mistake in how the derivative of the normal/tangent is computed with respect to the x or y directions. The derivative of the normalized vector (n_norm) wrt the non-normalized one (n) is a 3 x 3 matrix that should be fully multiplied with the vector (dn_x/dx, dn_y/dx, dn_z/dx) while currently only a single column is multiplied elementwise. This is only an issue for terrains with non-zero second-order derivatives. Changing these lines resulted in fewer incorrect gradient values according to IPOpt's gradient checker for me.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant