Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Update or remove non-ASCII test cases. #441

Closed
7 tasks done
Insti opened this issue Nov 6, 2016 · 2 comments
Closed
7 tasks done

Update or remove non-ASCII test cases. #441

Insti opened this issue Nov 6, 2016 · 2 comments
Labels
good first issue

Comments

@Insti
Copy link
Contributor

Insti commented Nov 6, 2016 •
edited by robkeim
Loading

In #428 the decision was made to remove test cases containing non-ASCII characers from exercises that are not explicitly about extended character set handling.

The following tests were identified as containing test cases that need to be fixed:

  • exercises/atbash-cipher/canonical-data.json
  • exercises/bob/canonical-data.json
  • exercises/forth/canonical-data.json
  • exercises/isogram/canonical-data.json
  • exercises/pangram/canonical-data.json
  • exercises/run-length-encoding/canonical-data.json
  • exercises/scrabble-score/canonical-data.json

Please check before removing a test that it is not also testing another property of the solution. If it is, please update the test to remove the non-ascii characters while maintaining the other intended purpose.
This was referenced Nov 6, 2016
Merged
Merged
@ldwoolley
Copy link

The discussion is still open? isn't it? I think handling unicode where ever possible future proofs the solutions and improves the programming solutions.

@stevejb71 stevejb71 mentioned this issue Nov 19, 2016
Merged
@petertseng petertseng mentioned this issue Nov 29, 2016
Merged
robkeim added a commit to robkeim/x-common that referenced this issue Jan 30, 2017
@robkeim
Remove non-ASCII characters to fix exercism#441
ece4bdf
@robkeim robkeim mentioned this issue Jan 30, 2017
Closed
@robkeim
Copy link
Contributor

robkeim commented Jan 30, 2017

I just sent out #527 which addresses atbash-cipher, forth, and scrabble-score.

The last exercise isogram was already addressed in #433.

robkeim added a commit to robkeim/x-common that referenced this issue Jan 30, 2017
@robkeim
Remove non-ASCII characters to fix exercism#441
2962254
@robkeim robkeim mentioned this issue Jan 30, 2017
Merged
@m-dango m-dango mentioned this issue Jan 31, 2017
Merged
@robkeim robkeim mentioned this issue Jan 31, 2017
Closed
rbasso pushed a commit to exercism/haskell that referenced this issue Feb 1, 2017
@petertseng @rbasso
forth: remove non-ASCII cases
e6c0172 
exercism/problem-specifications#529
exercism/problem-specifications#441
exercism/problem-specifications#428
rbasso pushed a commit to exercism/haskell that referenced this issue Feb 1, 2017
@petertseng @rbasso
atbash-cipher: remove non-ASCII cases
2ae21ea 
exercism/problem-specifications#529
exercism/problem-specifications#441
exercism/problem-specifications#428
rbasso pushed a commit to exercism/haskell that referenced this issue Feb 1, 2017
@petertseng @rbasso
scrabble-score: remove non-ASCII cases
785a3e5 
exercism/problem-specifications#529
exercism/problem-specifications#441
exercism/problem-specifications#428
@behrtam behrtam mentioned this issue Feb 22, 2017
Closed
behrtam added a commit to behrtam/python that referenced this issue Mar 8, 2017
@behrtam
word-count: Remove unicode test case
1bfda09 
As discussed in exercism/problem-specifications#441

Fixes exercism#416
@behrtam behrtam mentioned this issue Mar 8, 2017
Merged
behrtam added a commit to exercism/python that referenced this issue Mar 22, 2017
@behrtam
word-count: Remove unicode test case (#427)
217104e 
As discussed in exercism/problem-specifications#441

Fixes #416
@wojciechrak wojciechrak mentioned this issue Mar 27, 2017
Closed
@stevejb71 stevejb71 mentioned this issue Mar 27, 2017
Closed
@ricemery ricemery mentioned this issue Mar 31, 2017
Merged
@petertseng petertseng mentioned this issue Apr 27, 2017
Closed
@sjwarner-bp sjwarner-bp mentioned this issue Jul 19, 2018
Closed
emcoding pushed a commit that referenced this issue Nov 19, 2018
@bmulvihill @Insti
Update raindrops generator (#441)
dd458d4 
* Re-generate test file based on latest common test data.
* Simplify test generator by using `number` value from canonical-data.json to determine test name.
@rpottsoh rpottsoh mentioned this issue Dec 2, 2018
Closed
@m-dango m-dango mentioned this issue May 25, 2019
Merged
@rpottsoh rpottsoh mentioned this issue May 7, 2020
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
good first issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Insti @robkeim @ldwoolley