Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Pangram: Add the non-ascii test cases #741

Closed
wants to merge 1 commit into from
Closed

Pangram: Add the non-ascii test cases #741

wants to merge 1 commit into from

Conversation

cogitor
Copy link

@cogitor cogitor commented Mar 27, 2017

These are the canonical data changes for additional pangram tests I originally wanted to add to the xscala repo (exercism/scala#348)

The first non-ascii test already exists in the xscala repo (so this would only sync it up to common), while I wanted to add the second one as well:

I feel that another useful test would be a string with non-ascii characters, but with a missing character 'x'. This would invalidate solutions that are written to simply pass the previous test (e.g. by making the test for distinct characters be >= 26)

I am not sure if this would make sense for all languages, and what steps would be required to generate the per-language test cases.

Cheers!

@stevejb71
Copy link
Contributor

stevejb71 commented Mar 27, 2017

Non ascii test cases were removed earlier. See
#441

@cogitor
Copy link
Author

cogitor commented Mar 28, 2017

Figured that could've been the case and the scala tests weren't updated. That's fine, I can close this PR - how do you re-generate tests from the canonical file?

@stevejb71
Copy link
Contributor

Looking at the xscala repo, @ricemery has a test generator. If there is an automatic way of generating the tests he might well know, otherwise it would be done by hand.

@ricemery
Copy link
Member

The tests have to be updated manually. I have submitted a pull request - exercism/scala#350 . Hopefully is compiles, runs and is merged :)

Thanks

@cogitor
Copy link
Author

cogitor commented Mar 28, 2017

@ricemery awesome! I'm closing this one then, cheers

@cogitor cogitor closed this Mar 28, 2017
emcoding pushed a commit that referenced this pull request Nov 19, 2018
Add proper parsing logic for row, column coming from canonical data.
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants