Refactor device presentation #336
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timcowlishaw
force-pushed
the
refactor-device-presentation
branch
2 times, most recently
from
7cc1bec
to
c984b69
Compare
timcowlishaw
force-pushed
the
refactor-device-presentation
branch
from
c984b69
to
381e149
Compare
Future work: - improve test coverage (on presenters themselves) - Look into API versioning, use this representation in HTTP API too in a new version - Delete old formatting code once released. - Sort out the mess of different reading representations we use in different places and radically simplify that part of everything
timcowlishaw
force-pushed
the
refactor-device-presentation
branch
from
381e149
to
17384aa
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.