Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Refactor device presentation #336

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

Refactor device presentation #336

wants to merge 5 commits into from

Commits on Aug 31, 2024

  1. Remove deprecated avatars and uploads implementation

    @timcowlishaw
    timcowlishaw committed Aug 31, 2024
    Configuration menu
    Copy the full SHA
    8be5e6f View commit details
    Browse the repository at this point in the history

  2. Create new serialization logic and use to generate JSON for forwarding. 

    Future work:
- improve test coverage (on presenters themselves)
- Look into API versioning, use this representation in HTTP API too in a
  new version
- Delete old formatting code once released.
- Sort out the mess of different reading representations we use in
  different places and radically simplify that part of everything
    @timcowlishaw
    timcowlishaw committed Aug 31, 2024
    Configuration menu
    Copy the full SHA
    70c9492 View commit details
    Browse the repository at this point in the history

  3. use new device presentation for forwarding

    @timcowlishaw
    timcowlishaw committed Aug 31, 2024
    Configuration menu
    Copy the full SHA
    9dfe921 View commit details
    Browse the repository at this point in the history

  4. fix tests

    @timcowlishaw
    timcowlishaw committed Aug 31, 2024
    Configuration menu
    Copy the full SHA
    17384aa View commit details
    Browse the repository at this point in the history

  5. mark deprecatec model methods

    @timcowlishaw
    timcowlishaw committed Aug 31, 2024
    Configuration menu
    Copy the full SHA
    19c8a5d View commit details
    Browse the repository at this point in the history