Add deploy to Firebase CDN on template's README (Closes #374) #1143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gaearon You said in an issue that a PR explaining how to deploy to the Firebase CDN would be a good contribution, so i just sent a PR to solve it, feel free to comment about it! :) |
|
Thanks! I'm a bit behind the schedule reviewing things, sorry for that. |
|
Thanks! |
|
@gaearon No problem, thank you for your time! :D |
mofelee
added a commit
to xiaohu-developer/create-react-app
that referenced
this pull request
Dec 7, 2016
* master: (30 commits) Relax peerDependencies for ESLint preset (facebook#1191) Update Webpack to fix source map issues (facebook#1188) Update webpack prod config (facebook#1181) Chrome 'open tab' reuse an empty tab when possible (facebook#1165) Use file-loader for svgs (facebook#1180) Fix Babel issues in tests by applying the right transforms (facebook#1179) [babel-preset-react-app] Temporary fix missing babel plugins (facebook#1177) Add Subresource Integrity support (facebook#1176) Remove path module from webpack config on eject. (facebook#1175) Don't strip stack traces of evaluated webpack bundles (facebook#1050) Add deploy to Firebase CDN on template's README (Closes facebook#374) (facebook#1143) Update e2e.sh (facebook#1167) Document what npm build does and pushState (facebook#933) Fix minor typo/grammar (facebook#1099) Add "npm run build silently fails" to Troubleshooting (facebook#1168) Add testURL to jest config (facebook#1120) Make jsx-no-undef rule an error (facebook#1159) Update CHANGELOG.md Publish Update changelog for 0.8.1 ...
alexdriaguine
pushed a commit
to alexdriaguine/create-react-app
that referenced
this pull request
Jan 23, 2017
…facebook#1143) * Add deploy to Firebase CDN on template's README (Closes facebook#374) * Move section and minor tweaks
randycoulman
pushed a commit
to CodingZeal/create-react-app
that referenced
this pull request
May 8, 2017
…facebook#1143) * Add deploy to Firebase CDN on template's README (Closes facebook#374) * Move section and minor tweaks
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A step by step guide to deploying a recent created react app (with create-react-app) to the Firebase CDN.