Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Set crossOriginLoading to anonymous in output #1181

Merged
merged 1 commit into from
Dec 7, 2016
Merged

Set crossOriginLoading to anonymous in output #1181

merged 1 commit into from
Dec 7, 2016

Conversation

XVincentX
Copy link

@XVincentX XVincentX commented Dec 6, 2016

@gaearon This is a follow up to #1176 - I discovered a small issue while making intensive tests till I landed here: waysact/webpack-subresource-integrity#20

@XVincentX
Copy link
Author

@gaearon gaearon merged commit 45c0426 into facebook:master Dec 7, 2016
@gaearon gaearon added this to the 0.8.2 milestone Dec 7, 2016
@gaearon
Copy link
Contributor

gaearon commented Dec 7, 2016

Thanks. Can you describe this in a few words?

@XVincentX XVincentX deleted the patch-1 branch December 7, 2016 12:27
@XVincentX
Copy link
Author

Webpack has an option output.crossOriginLoading used for loading chunks with code splitting. webpack-subresource-integrity plugin offers a similar option which is now deprecated, preferring the webpack-config-file-level option.

Does that clarify the thing?

mofelee added a commit to xiaohu-developer/create-react-app that referenced this pull request Dec 7, 2016
* master: (30 commits)
  Relax peerDependencies for ESLint preset (facebook#1191)
  Update Webpack to fix source map issues (facebook#1188)
  Update webpack prod config (facebook#1181)
  Chrome 'open tab' reuse an empty tab when possible (facebook#1165)
  Use file-loader for svgs (facebook#1180)
  Fix Babel issues in tests by applying the right transforms (facebook#1179)
  [babel-preset-react-app] Temporary fix missing babel plugins (facebook#1177)
  Add Subresource Integrity support (facebook#1176)
  Remove path module from webpack config on eject. (facebook#1175)
  Don't strip stack traces of evaluated webpack bundles (facebook#1050)
  Add deploy to Firebase CDN on template's README (Closes facebook#374) (facebook#1143)
  Update e2e.sh (facebook#1167)
  Document what npm build does and pushState (facebook#933)
  Fix minor typo/grammar (facebook#1099)
  Add "npm run build silently fails" to Troubleshooting (facebook#1168)
  Add testURL to jest config (facebook#1120)
  Make jsx-no-undef rule an error (facebook#1159)
  Update CHANGELOG.md
  Publish
  Update changelog for 0.8.1
  ...
alexdriaguine pushed a commit to alexdriaguine/create-react-app that referenced this pull request Jan 23, 2017
randycoulman pushed a commit to CodingZeal/create-react-app that referenced this pull request May 8, 2017
@lock lock bot locked and limited conversation to collaborators Jan 21, 2019
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants