Skip to content

React Native 0.74.0-rc.4: use_ccache is broken: no ccache wrapper script ccache-clang.sh bundled in npm package #43633

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
CatStudioApp opened this issue Mar 24, 2024 · 2 comments · Fixed by #43900, #45220, #45580 or #48885
Labels
📦Bundler Resolution: Fixed A PR that fixes this issue has been merged.

Comments

@CatStudioApp
Copy link
Contributor

Description

if use_ccache, it would find wrapper scripts in this path node_modules/react-native/scripts/xcode/... but this directory does not contain that script
https://github.com/facebook/react-native/blob/main/packages/react-native/scripts/xcode/ccache-clang.sh

image

Steps to reproduce

N/A

React Native Version

0.74.0-rc.4

Affected Platforms

Runtime - iOS

Output of npx react-native info

N/A

Stacktrace or Logs

N/A

Reproducer

N/A

Screenshots and Videos

No response

@github-actions github-actions bot added 📦Bundler Needs: Author Feedback Needs: Repro This issue could be improved with a clear list of steps to reproduce the issue. labels Mar 24, 2024
Copy link

⚠️ Missing Reproducible Example
ℹ️ We could not detect a reproducible example in your issue report. Please provide either:
  • If your bug is UI related: a Snack
  • If your bug is build/update related: use our Reproducer Template. A reproducer needs to be in a GitHub repository under your username.

@cortinico
Copy link
Contributor

Thanks for the report. This will be included in 0.74 RC6

@cortinico cortinico added Resolution: PR Submitted A pull request with a fix has been provided. and removed Needs: Triage 🔍 Needs: Author Feedback Needs: Repro This issue could be improved with a clear list of steps to reproduce the issue. labels Mar 25, 2024
@cortinico cortinico added Resolution: Fixed A PR that fixes this issue has been merged. and removed Resolution: PR Submitted A pull request with a fix has been provided. labels Mar 25, 2024
huntie pushed a commit that referenced this issue Apr 2, 2024
)

Summary:
I found in 0.74.0-rc.x, `ccache_enabled` is introduced. However, it is not being delivered via npm.

fixes #43633

Changelog: [iOS] [Fixed] - Adding ccache_clang wrapper scripts to package.json for distribution

Pull Request resolved: #43634

Reviewed By: cortinico

Differential Revision: D55308743

Pulled By: blakef

fbshipit-source-id: e89a4bb3a1fbf8562d880b4c9d25dc9083717ba6
This was referenced Jun 28, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment