Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[LOCAL] Fix broken Android tests for 0.72 #38926

Merged
merged 1 commit into from
Aug 10, 2023
Merged

[LOCAL] Fix broken Android tests for 0.72 #38926

merged 1 commit into from
Aug 10, 2023

Conversation

cortinico
Copy link
Contributor

Summary:

JVM Tests for 0.72 are failing to compile due to a missing ShadowSoLoader class which exists in main. I'm adding it here.

Changelog:

[INTERNAL] - [LOCAL] Fix broken Android tests for 0.72

Test Plan:

Tests are green locally, so should they be on CI

@cortinico cortinico requested a review from lunaleaps August 10, 2023 16:00
@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Aug 10, 2023
@cortinico cortinico requested review from Titozzz and fortmarek August 10, 2023 16:00
@lunaleaps lunaleaps merged commit 7b55c7d into 0.72-stable Aug 10, 2023
@lunaleaps lunaleaps deleted the nc/fix-tests-for-072 branch August 10, 2023 16:57
lunaleaps pushed a commit that referenced this pull request Aug 10, 2023
@cortinico
[LOCAL] Fix broken Android tests for 0.72 (#38926)
2f6c200
@cipolleschi cipolleschi mentioned this pull request Aug 12, 2023
Merged
Kudo pushed a commit to expo/react-native that referenced this pull request Aug 21, 2023
@cortinico @Kudo
[LOCAL] Fix broken Android tests for 0.72 (facebook#38926)
a6ccde6
@NOUIY NOUIY mentioned this pull request Sep 4, 2023
Open
@cipolleschi cipolleschi mentioned this pull request Sep 21, 2023
Merged
@cipolleschi cipolleschi mentioned this pull request Oct 12, 2023
Merged
@NOUIY NOUIY mentioned this pull request Oct 16, 2023
Open
@cipolleschi cipolleschi mentioned this pull request Nov 1, 2023
Merged
@cipolleschi cipolleschi mentioned this pull request Dec 27, 2023
Merged
This was referenced Jan 4, 2024
Merged
Merged
Merged
Closed
This was referenced Feb 28, 2024
Merged
Merged
Merged
@cipolleschi cipolleschi mentioned this pull request Jun 28, 2024
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@lunaleaps lunaleaps Awaiting requested review from lunaleaps

@Titozzz Titozzz Awaiting requested review from Titozzz

@fortmarek fortmarek Awaiting requested review from fortmarek

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner Pick Request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cortinico @lunaleaps @facebook-github-bot