feat: build visionos hermes binary on the CI #44691
Closed
+71
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
okwasniewski
force-pushed
the
feat/visionos-hermes
branch
2 times, most recently
from
09f7147 to
fadd7fe
Compare
okwasniewski
commented
May 27, 2024
okwasniewski
force-pushed
the
feat/visionos-hermes
branch
from
fadd7fe to
cf057c4
Compare
facebook-github-bot
added
the
Shared with Meta
okwasniewski
force-pushed
the
feat/visionos-hermes
branch
from
cf057c4 to
609b136
Compare
Base commit: e0a2e86 |
|
Hi @okwasniewski, thanks for the PR. It looks good on CircleCI, but we are migrating the jobs from CCI to GHA. 😅 Would you mind porting your changes there as well? 🙏 |
okwasniewski
force-pushed
the
feat/visionos-hermes
branch
from
4b25984 to
930affa
Compare
|
Hey @cipolleschi, sure no problem! I'll work on porting the changes to GH |
okwasniewski
force-pushed
the
feat/visionos-hermes
branch
from
930affa to
96f59b5
Compare
test: bump versions
okwasniewski
force-pushed
the
feat/visionos-hermes
branch
from
96f59b5 to
29d24da
Compare
cipolleschi
reviewed
Jun 5, 2024
Comment on lines
+159
to
+162
| mkdir -p "destroot/bin" | ||
| for platform in "${PLATFORMS[@]}"; do | ||
| mkdir -p "destroot/Library/Frameworks/$platform" | ||
| cp -R "./build_$platform/API/hermes/hermes.framework"* "destroot/Library/Frameworks/$platform" |
There was a problem hiding this comment.
thanks for the cleanup!
cipolleschi
approved these changes
Jun 5, 2024
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@cipolleschi merged this pull request in 924fb3d. |
|
This pull request was successfully merged by @okwasniewski in 924fb3d. When will my fix make it into a release? | How to file a pick request? |
okwasniewski
added a commit
to okwasniewski/react-native
that referenced
this pull request
Jun 24, 2024
Summary: As discussed with cipolleschi offline, this PR adds visionOS to the prebuilt Hermes binary for the CI. [IOS] [ADDED] - Prebuilt version of Hermes for visionOS Pull Request resolved: facebook#44691 Test Plan: Check if CI builds xcframework for visionOS. Reviewed By: cortinico Differential Revision: D58189271 Pulled By: cipolleschi fbshipit-source-id: dc76746b2c1e22670bef4c21411a598e43dad577
Titozzz
pushed a commit
that referenced
this pull request
Jul 22, 2024
Summary: As discussed with cipolleschi offline, this PR adds visionOS to the prebuilt Hermes binary for the CI. [IOS] [ADDED] - Prebuilt version of Hermes for visionOS Pull Request resolved: #44691 Test Plan: Check if CI builds xcframework for visionOS. Reviewed By: cortinico Differential Revision: D58189271 Pulled By: cipolleschi fbshipit-source-id: dc76746b2c1e22670bef4c21411a598e43dad577
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
As discussed with @cipolleschi offline, this PR adds visionOS to the prebuilt Hermes binary for the CI.
Changelog:
[IOS] [ADDED] - Prebuilt version of Hermes for visionOS
Test Plan:
Check if CI builds xcframework for visionOS.