Skip to content

Temporarily feature flag numeric fallback for symbols #24401

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Apr 19, 2022

Conversation

rickhanlonii
Copy link
Member

Overview

We need these until it's safe to remove them in some internal surfaces.

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Apr 19, 2022
@sizebot
Copy link

sizebot commented Apr 19, 2022

Comparing: d63cd97...becaffd

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 131.43 kB 131.43 kB = 42.05 kB 42.05 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 136.70 kB 136.70 kB = 43.64 kB 43.64 kB
facebook-www/ReactDOM-prod.classic.js +0.14% 435.12 kB 435.75 kB +0.15% 79.88 kB 80.00 kB
facebook-www/ReactDOM-prod.modern.js +0.15% 420.12 kB 420.73 kB +0.16% 77.51 kB 77.63 kB
facebook-www/ReactDOMForked-prod.classic.js +0.14% 435.12 kB 435.75 kB +0.15% 79.88 kB 80.00 kB
facebook-www/ReactFlightDOMRelayClient-dev.classic.js +20.16% 10.58 kB 12.71 kB +17.99% 3.16 kB 3.73 kB
facebook-www/ReactFlightDOMRelayClient-dev.modern.js +20.16% 10.58 kB 12.71 kB +17.96% 3.16 kB 3.73 kB
facebook-www/JSXDEVRuntime-prod.classic.js +14.69% 0.43 kB 0.49 kB +13.76% 0.30 kB 0.34 kB
facebook-www/JSXDEVRuntime-prod.modern.js +14.69% 0.43 kB 0.49 kB +13.76% 0.30 kB 0.34 kB
facebook-www/JSXDEVRuntime-profiling.classic.js +14.69% 0.43 kB 0.49 kB +13.76% 0.30 kB 0.34 kB
facebook-www/JSXDEVRuntime-profiling.modern.js +14.69% 0.43 kB 0.49 kB +13.76% 0.30 kB 0.34 kB
facebook-www/ReactFreshRuntime-dev.classic.js +11.25% 20.58 kB 22.89 kB +10.30% 6.02 kB 6.64 kB
facebook-www/ReactFreshRuntime-dev.modern.js +11.25% 20.58 kB 22.89 kB +10.31% 6.02 kB 6.64 kB
facebook-www/ReactIs-prod.classic.js +11.12% 5.09 kB 5.66 kB +10.44% 1.26 kB 1.39 kB
facebook-www/ReactIs-prod.modern.js +11.12% 5.09 kB 5.66 kB +10.44% 1.26 kB 1.39 kB
facebook-www/ReactIs-dev.modern.js +4.41% 9.52 kB 9.94 kB +1.15% 2.53 kB 2.55 kB
facebook-www/ReactIs-dev.classic.js +4.41% 9.52 kB 9.94 kB +1.15% 2.53 kB 2.55 kB
facebook-www/React-prod.modern.js +3.23% 18.47 kB 19.07 kB +2.49% 4.66 kB 4.78 kB
facebook-www/React-prod.classic.js +3.21% 18.62 kB 19.21 kB +2.51% 4.71 kB 4.83 kB
facebook-www/React-profiling.modern.js +3.13% 19.07 kB 19.67 kB +2.34% 4.79 kB 4.90 kB
facebook-www/React-profiling.classic.js +3.11% 19.22 kB 19.82 kB +2.34% 4.84 kB 4.95 kB
facebook-www/ReactFlightDOMRelayClient-prod.classic.js +2.23% 6.14 kB 6.28 kB +3.03% 1.85 kB 1.90 kB
facebook-www/ReactFlightDOMRelayClient-prod.modern.js +2.23% 6.14 kB 6.28 kB +3.03% 1.85 kB 1.90 kB
facebook-react-native/react-is/cjs/ReactIs-dev.js = 7.31 kB 7.09 kB = 1.96 kB 1.83 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
facebook-www/ReactFlightDOMRelayClient-dev.classic.js +20.16% 10.58 kB 12.71 kB +17.99% 3.16 kB 3.73 kB
facebook-www/ReactFlightDOMRelayClient-dev.modern.js +20.16% 10.58 kB 12.71 kB +17.96% 3.16 kB 3.73 kB
facebook-www/JSXDEVRuntime-prod.classic.js +14.69% 0.43 kB 0.49 kB +13.76% 0.30 kB 0.34 kB
facebook-www/JSXDEVRuntime-prod.modern.js +14.69% 0.43 kB 0.49 kB +13.76% 0.30 kB 0.34 kB
facebook-www/JSXDEVRuntime-profiling.classic.js +14.69% 0.43 kB 0.49 kB +13.76% 0.30 kB 0.34 kB
facebook-www/JSXDEVRuntime-profiling.modern.js +14.69% 0.43 kB 0.49 kB +13.76% 0.30 kB 0.34 kB
facebook-www/ReactFreshRuntime-dev.classic.js +11.25% 20.58 kB 22.89 kB +10.30% 6.02 kB 6.64 kB
facebook-www/ReactFreshRuntime-dev.modern.js +11.25% 20.58 kB 22.89 kB +10.31% 6.02 kB 6.64 kB
facebook-www/ReactIs-prod.classic.js +11.12% 5.09 kB 5.66 kB +10.44% 1.26 kB 1.39 kB
facebook-www/ReactIs-prod.modern.js +11.12% 5.09 kB 5.66 kB +10.44% 1.26 kB 1.39 kB
facebook-www/ReactIs-dev.modern.js +4.41% 9.52 kB 9.94 kB +1.15% 2.53 kB 2.55 kB
facebook-www/ReactIs-dev.classic.js +4.41% 9.52 kB 9.94 kB +1.15% 2.53 kB 2.55 kB
facebook-www/React-prod.modern.js +3.23% 18.47 kB 19.07 kB +2.49% 4.66 kB 4.78 kB
facebook-www/React-prod.classic.js +3.21% 18.62 kB 19.21 kB +2.51% 4.71 kB 4.83 kB
facebook-www/React-profiling.modern.js +3.13% 19.07 kB 19.67 kB +2.34% 4.79 kB 4.90 kB
facebook-www/React-profiling.classic.js +3.11% 19.22 kB 19.82 kB +2.34% 4.84 kB 4.95 kB
facebook-www/ReactFlightDOMRelayClient-prod.classic.js +2.23% 6.14 kB 6.28 kB +3.03% 1.85 kB 1.90 kB
facebook-www/ReactFlightDOMRelayClient-prod.modern.js +2.23% 6.14 kB 6.28 kB +3.03% 1.85 kB 1.90 kB
facebook-www/JSXDEVRuntime-dev.modern.js +1.08% 45.25 kB 45.74 kB +0.25% 12.82 kB 12.85 kB
facebook-www/JSXDEVRuntime-dev.classic.js +1.08% 45.25 kB 45.74 kB +0.25% 12.82 kB 12.85 kB
facebook-www/ReactDOMServer-prod.classic.js +0.98% 47.25 kB 47.71 kB +0.93% 11.03 kB 11.14 kB
facebook-www/ReactFlightDOMRelayServer-prod.classic.js +0.84% 26.71 kB 26.93 kB +0.88% 7.03 kB 7.09 kB
facebook-www/ReactFlightDOMRelayServer-prod.modern.js +0.83% 26.78 kB 27.01 kB +0.89% 7.06 kB 7.13 kB
facebook-www/ReactDOMServer-prod.modern.js +0.69% 75.60 kB 76.13 kB +0.65% 15.62 kB 15.72 kB
facebook-www/ReactDOMServerStreaming-prod.modern.js +0.68% 77.43 kB 77.95 kB +0.75% 16.42 kB 16.55 kB
facebook-react-native/react-is/cjs/ReactIs-prod.js +0.50% 4.78 kB 4.80 kB +0.35% 1.15 kB 1.15 kB
facebook-react-native/react-is/cjs/ReactIs-profiling.js +0.50% 4.78 kB 4.80 kB +0.35% 1.15 kB 1.15 kB
facebook-www/React-dev.modern.js +0.44% 116.36 kB 116.87 kB +0.11% 28.81 kB 28.84 kB
facebook-www/React-dev.classic.js +0.44% 117.38 kB 117.89 kB +0.10% 29.01 kB 29.04 kB
facebook-www/ReactDOMServer-dev.classic.js +0.32% 157.01 kB 157.52 kB +0.33% 39.74 kB 39.87 kB
facebook-www/ReactFlightDOMRelayServer-dev.classic.js +0.25% 53.19 kB 53.32 kB +0.09% 13.51 kB 13.52 kB
facebook-www/ReactFlightDOMRelayServer-dev.modern.js +0.25% 53.24 kB 53.37 kB +0.08% 13.52 kB 13.54 kB
facebook-www/ReactART-prod.modern.js +0.23% 268.44 kB 269.05 kB +0.25% 47.75 kB 47.87 kB
facebook-www/ReactART-prod.classic.js +0.23% 279.22 kB 279.85 kB +0.24% 49.54 kB 49.66 kB
facebook-react-native/react/cjs/React-dev.js = 104.88 kB 104.65 kB = 25.68 kB 25.58 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-writer.node.development.server.js = 63.08 kB 62.91 kB = 16.12 kB 16.04 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-writer.node.development.server.js = 63.02 kB 62.85 kB = 16.10 kB 16.03 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-writer.node.development.server.js = 63.02 kB 62.85 kB = 16.10 kB 16.03 kB
oss-experimental/react-server-dom-webpack/umd/react-server-dom-webpack-writer.browser.development.server.js = 64.46 kB 64.29 kB = 16.14 kB 16.06 kB
oss-stable-semver/react-server-dom-webpack/umd/react-server-dom-webpack-writer.browser.development.server.js = 64.40 kB 64.23 kB = 16.12 kB 16.05 kB
oss-stable/react-server-dom-webpack/umd/react-server-dom-webpack-writer.browser.development.server.js = 64.40 kB 64.23 kB = 16.12 kB 16.05 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-writer.browser.development.server.js = 61.30 kB 61.13 kB = 15.93 kB 15.85 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-writer.browser.development.server.js = 61.25 kB 61.08 kB = 15.91 kB 15.83 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-writer.browser.development.server.js = 61.25 kB 61.08 kB = 15.91 kB 15.83 kB
oss-experimental/react/cjs/react-jsx-runtime.development.js = 42.04 kB 41.91 kB = 12.30 kB 12.23 kB
oss-experimental/react/cjs/react-jsx-dev-runtime.development.js = 41.45 kB 41.32 kB = 12.12 kB 12.05 kB
oss-stable-semver/react/cjs/react-jsx-runtime.development.js = 41.71 kB 41.58 kB = 12.23 kB 12.16 kB
oss-stable/react/cjs/react-jsx-runtime.development.js = 41.71 kB 41.58 kB = 12.23 kB 12.16 kB
oss-stable-semver/react/cjs/react-jsx-dev-runtime.development.js = 41.12 kB 40.98 kB = 12.06 kB 11.98 kB
oss-stable/react/cjs/react-jsx-dev-runtime.development.js = 41.12 kB 40.98 kB = 12.06 kB 11.98 kB
oss-experimental/react-noop-renderer/cjs/react-noop-renderer-persistent.development.js = 40.69 kB 40.51 kB = 9.06 kB 8.98 kB
oss-stable-semver/react-noop-renderer/cjs/react-noop-renderer-persistent.development.js = 40.69 kB 40.51 kB = 9.06 kB 8.98 kB
oss-stable/react-noop-renderer/cjs/react-noop-renderer-persistent.development.js = 40.69 kB 40.51 kB = 9.06 kB 8.98 kB
oss-experimental/react-noop-renderer/cjs/react-noop-renderer.development.js = 40.56 kB 40.38 kB = 9.05 kB 8.97 kB
oss-stable-semver/react-noop-renderer/cjs/react-noop-renderer.development.js = 40.56 kB 40.38 kB = 9.05 kB 8.97 kB
oss-stable/react-noop-renderer/cjs/react-noop-renderer.development.js = 40.56 kB 40.38 kB = 9.05 kB 8.97 kB
oss-experimental/react-server/cjs/react-server-flight.development.js = 38.48 kB 38.31 kB = 9.78 kB 9.69 kB
oss-stable-semver/react-server/cjs/react-server-flight.development.js = 38.48 kB 38.31 kB = 9.78 kB 9.69 kB
oss-stable/react-server/cjs/react-server-flight.development.js = 38.48 kB 38.31 kB = 9.78 kB 9.69 kB
facebook-relay/flight/ReactFlightNativeRelayServer-dev.js = 38.86 kB 38.68 kB = 9.88 kB 9.80 kB
facebook-react-native/react/cjs/JSXRuntime-dev.js = 36.19 kB 35.97 kB = 10.46 kB 10.36 kB
facebook-react-native/react/cjs/JSXDEVRuntime-dev.js = 35.59 kB 35.37 kB = 10.29 kB 10.18 kB
oss-experimental/react-server-dom-webpack/umd/react-server-dom-webpack.development.js = 17.58 kB 17.40 kB = 4.84 kB 4.76 kB
oss-stable-semver/react-server-dom-webpack/umd/react-server-dom-webpack.development.js = 17.58 kB 17.40 kB = 4.84 kB 4.76 kB
oss-stable/react-server-dom-webpack/umd/react-server-dom-webpack.development.js = 17.58 kB 17.40 kB = 4.84 kB 4.76 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack.development.js = 16.36 kB 16.19 kB = 4.71 kB 4.63 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack.development.js = 16.36 kB 16.19 kB = 4.71 kB 4.63 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack.development.js = 16.36 kB 16.19 kB = 4.71 kB 4.63 kB
oss-experimental/react-client/cjs/react-client-flight.development.js = 13.82 kB 13.64 kB = 4.07 kB 4.00 kB
oss-stable-semver/react-client/cjs/react-client-flight.development.js = 13.82 kB 13.64 kB = 4.07 kB 4.00 kB
oss-stable/react-client/cjs/react-client-flight.development.js = 13.82 kB 13.64 kB = 4.07 kB 4.00 kB
oss-experimental/react-is/umd/react-is.development.js = 7.90 kB 7.77 kB = 2.09 kB 2.01 kB
oss-stable-semver/react-is/umd/react-is.development.js = 7.88 kB 7.74 kB = 2.09 kB 2.00 kB
oss-stable/react-is/umd/react-is.development.js = 7.88 kB 7.74 kB = 2.09 kB 2.00 kB
facebook-relay/flight/ReactFlightNativeRelayClient-dev.js = 10.58 kB 10.41 kB = 3.16 kB 3.08 kB
oss-experimental/jest-react/cjs/jest-react.development.js = 9.93 kB 9.75 kB = 3.46 kB 3.37 kB
oss-stable-semver/jest-react/cjs/jest-react.development.js = 9.93 kB 9.75 kB = 3.46 kB 3.37 kB
oss-stable/jest-react/cjs/jest-react.development.js = 9.93 kB 9.75 kB = 3.46 kB 3.37 kB
oss-experimental/react-is/cjs/react-is.development.js = 7.35 kB 7.22 kB = 2.01 kB 1.93 kB
oss-stable-semver/react-is/cjs/react-is.development.js = 7.33 kB 7.20 kB = 2.01 kB 1.92 kB
oss-stable/react-is/cjs/react-is.development.js = 7.33 kB 7.20 kB = 2.01 kB 1.92 kB
facebook-react-native/react-is/cjs/ReactIs-dev.js = 7.31 kB 7.09 kB = 1.96 kB 1.83 kB

Generated by 🚫 dangerJS against becaffd

@rickhanlonii rickhanlonii merged commit 4175f05 into facebook:main Apr 19, 2022
@rickhanlonii rickhanlonii deleted the rh-ff-symbols branch April 26, 2022 14:04
facebook-github-bot pushed a commit to facebook/react-native that referenced this pull request Apr 26, 2022
Summary:
This sync includes the following changes:
- **[bd4784c8f](facebook/react@bd4784c8f )**: Revert #24236 (Don't recreate the same fallback on the client if hydrating suspends) ([#24434](facebook/react#24434)) //<dan>//
- **[6d3b6d0f4](facebook/react@6d3b6d0f4 )**: forwardRef et al shouldn't affect if props reused ([#24421](facebook/react#24421)) //<Andrew Clark>//
- **[bd0813766](facebook/react@bd0813766 )**: Fix: useDeferredValue should reuse previous value ([#24413](facebook/react#24413)) //<Andrew Clark>//
- **[9ae80d6a2](facebook/react@9ae80d6a2 )**: Suppress hydration warnings when a preceding sibling suspends ([#24404](facebook/react#24404)) //<Josh Story>//
- **[0dc4e6663](facebook/react@0dc4e6663 )**: Land enableClientRenderFallbackOnHydrationMismatch ([#24410](facebook/react#24410)) //<Andrew Clark>//
- **[354772952](facebook/react@354772952 )**: Land enableSelectiveHydration flag ([#24406](facebook/react#24406)) //<Andrew Clark>//
- **[392808a1f](facebook/react@392808a1f )**: Land enableClientRenderFallbackOnTextMismatch flag ([#24405](facebook/react#24405)) //<Andrew Clark>//
- **[1e748b452](facebook/react@1e748b452 )**: Land enableLazyElements flag ([#24407](facebook/react#24407)) //<Andrew Clark>//
- **[4175f0593](facebook/react@4175f0593 )**: Temporarily feature flag numeric fallback for symbols ([#24401](facebook/react#24401)) //<Ricky>//
- **[a6d53f346](facebook/react@a6d53f346 )**: Revert "Clean up Selective Hydration / Event Replay flag ([#24156](facebook/react#24156))" ([#24402](facebook/react#24402)) //<Ricky>//
- **[ab9cdd34f](facebook/react@ab9cdd34f )**: Bugfix: In legacy mode, call suspended tree's unmount effects when it is deleted ([#24400](facebook/react#24400)) //<Andrew Clark>//
- **[168da8d55](facebook/react@168da8d55 )**: Fix typo that happened during rebasing //<Andrew Clark>//
- **[8bc527a4c](facebook/react@8bc527a4c )**: Bugfix: Fix race condition between interleaved and non-interleaved updates ([#24353](facebook/react#24353)) //<Andrew Clark>//
- **[f7cf077cc](facebook/react@f7cf077cc )**: [Transition Tracing] Add Offscreen Queue ([#24341](facebook/react#24341)) //<Luna Ruan>//
- **[4fc394bbe](facebook/react@4fc394bbe )**: Fix suspense fallback throttling ([#24253](facebook/react#24253)) //<sunderls>//
- **[80170a068](facebook/react@80170a068 )**: Match bundle.name and match upper case entry points ([#24346](facebook/react#24346)) //<Sebastian Markbåge>//
- **[fea6f8da6](facebook/react@fea6f8da6 )**: [Transition Tracing] Add transition to OffscreenState and pendingSuspenseBoundaries to RootState ([#24340](facebook/react#24340)) //<Luna Ruan>//
- **[8e2f9b086](facebook/react@8e2f9b086 )**: move passive flag ([#24339](facebook/react#24339)) //<Luna Ruan>//
- **[55a21ef7e](facebook/react@55a21ef7e )**: fix pushTransition for transition tracing ([#24338](facebook/react#24338)) //<Luna Ruan>//
- **[069d23bb7](facebook/react@069d23bb7 )**:  [eslint-plugin-exhaustive-deps] Fix exhaustive deps check for unstable vars ([#24343](facebook/react#24343)) //<Afzal Sayed>//
- **[4997515b9](facebook/react@4997515b9 )**: Point useSubscription to useSyncExternalStore shim ([#24289](facebook/react#24289)) //<dan>//
- **[01e2bff1d](facebook/react@01e2bff1d )**: Remove unnecessary check ([#24332](facebook/react#24332)) //<zhoulixiang>//
- **[d9a0f9e20](facebook/react@d9a0f9e20 )**: Delete create-subscription folder ([#24288](facebook/react#24288)) //<dan>//
- **[f993ffc51](facebook/react@f993ffc51 )**: Fix infinite update loop that happens when an unmemoized value is passed to useDeferredValue ([#24247](facebook/react#24247)) //<Andrew Clark>//
- **[fa5800226](facebook/react@fa5800226 )**: [Fizz] Pipeable Stream Perf ([#24291](facebook/react#24291)) //<Josh Story>//
- **[0568c0f8c](facebook/react@0568c0f8c )**: Replace zero with NoLanes for consistency in FiberLane ([#24327](facebook/react#24327)) //<Leo>//
- **[e0160d50c](facebook/react@e0160d50c )**: add transition tracing transitions stack ([#24321](facebook/react#24321)) //<Luna Ruan>//
- **[b0f13e5d3](facebook/react@b0f13e5d3 )**: add pendingPassiveTransitions ([#24320](facebook/react#24320)) //<Luna Ruan>//

Changelog:
[General][Changed] - React Native sync for revisions 60e63b9...bd4784c

jest_e2e[run_all_tests]

Reviewed By: kacieb

Differential Revision: D35899012

fbshipit-source-id: 86a885e336fca9f0efa80cd2b8ca040f2cb53853
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants