forwardRef et al shouldn't affect if props object is reused

[acdlite]

We don't have strong guarantees that the props object is referentially equal during updates where we can't bail out anyway — like if the props are shallowly equal, but there's a local state or context update in the same batch.

However, as a principle, we should aim to make the behavior consistent across different ways of memoizing a component. For example, React.memo has a different internal Fiber layout if you pass a normal function component (SimpleMemoComponent) versus if you pass a different type like forwardRef (MemoComponent). But this is an implementation detail. Wrapping a component in forwardRef (or React.lazy, etc) shouldn't affect whether the props object is reused during a bailout.

[sizebot]

Comparing: bd08137...3b190a6

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name	+/-	Base	Current	+/- gzip	Base gzip	Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js	+0.02%	131.53 kB	131.56 kB	+0.03%	42.11 kB	42.12 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js	+0.02%	136.80 kB	136.83 kB	+0.01%	43.68 kB	43.69 kB
facebook-www/ReactDOM-prod.classic.js	+0.03%	441.05 kB	441.18 kB	+0.03%	80.44 kB	80.46 kB
facebook-www/ReactDOM-prod.modern.js	+0.03%	426.30 kB	426.43 kB	+0.03%	78.26 kB	78.28 kB
facebook-www/ReactDOMForked-prod.classic.js	+0.03%	441.05 kB	441.18 kB	+0.03%	80.44 kB	80.46 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 3b190a6

[Andarist]

nice! so in a way, my fix was same(ish):

react/packages/react-reconciler/src/ReactFiberBeginWork.new.js

Lines 597 to 599 in bd13426

	workInProgress.pendingProps = nextProps = shallowEqual(prevProps, nextProps)
	? prevProps
	: nextProps;

this one is "just" applied at a more proper, generic, level 👍

[acdlite]

yeah it's essentially the same, I just kept the shallowEqual call where it already was