Skip to content

Remove Symbol Polyfill (again) #25144

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Aug 25, 2022
Merged

Remove Symbol Polyfill (again) #25144

merged 1 commit into from
Aug 25, 2022

Conversation

rickhanlonii
Copy link
Member

Overview

This has landed internally so we can remove it from the internal fork and clean up the code a bit.

@rickhanlonii rickhanlonii force-pushed the rh-rm-symbol-polyfill branch from d5d99c7 to 8dede3e Compare August 25, 2022 18:47
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Aug 25, 2022
@sizebot
Copy link

sizebot commented Aug 25, 2022

Comparing: b6978bc...8dede3e

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 134.98 kB 134.98 kB = 43.23 kB 43.23 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 141.64 kB 141.64 kB = 45.20 kB 45.20 kB
facebook-www/ReactDOM-prod.classic.js = 486.69 kB 486.06 kB = 86.63 kB 86.51 kB
facebook-www/ReactDOM-prod.modern.js = 471.95 kB 471.34 kB = 84.42 kB 84.29 kB
facebook-www/ReactDOMForked-prod.classic.js = 486.69 kB 486.06 kB = 86.63 kB 86.51 kB
facebook-www/ReactFlightDOMRelayClient-prod.classic.js = 6.34 kB 6.21 kB = 1.92 kB 1.87 kB
facebook-www/ReactFlightDOMRelayClient-prod.modern.js = 6.34 kB 6.21 kB = 1.92 kB 1.87 kB
facebook-www/React-profiling.modern.js = 20.16 kB 19.56 kB = 5.01 kB 4.89 kB
facebook-www/React-prod.modern.js = 19.55 kB 18.95 kB = 4.89 kB 4.76 kB
facebook-www/React-profiling.classic.js = 20.47 kB 19.85 kB = 5.10 kB 4.98 kB
facebook-www/React-prod.classic.js = 19.87 kB 19.24 kB = 4.98 kB 4.85 kB
facebook-www/ReactIs-dev.classic.js = 10.15 kB 9.62 kB = 2.61 kB 2.54 kB
facebook-www/ReactIs-dev.modern.js = 10.15 kB 9.62 kB = 2.61 kB 2.54 kB
facebook-www/ReactIs-prod.classic.js = 5.94 kB 5.35 kB = 1.45 kB 1.30 kB
facebook-www/ReactIs-prod.modern.js = 5.94 kB 5.35 kB = 1.45 kB 1.30 kB
facebook-www/ReactFreshRuntime-dev.modern.js = 23.00 kB 20.58 kB = 6.68 kB 6.02 kB
facebook-www/ReactFreshRuntime-dev.classic.js = 23.00 kB 20.58 kB = 6.68 kB 6.02 kB
facebook-www/JSXDEVRuntime-prod.classic.js = 0.49 kB 0.43 kB = 0.34 kB 0.30 kB
facebook-www/JSXDEVRuntime-prod.modern.js = 0.49 kB 0.43 kB = 0.34 kB 0.30 kB
facebook-www/JSXDEVRuntime-profiling.classic.js = 0.49 kB 0.43 kB = 0.34 kB 0.30 kB
facebook-www/JSXDEVRuntime-profiling.modern.js = 0.49 kB 0.43 kB = 0.34 kB 0.30 kB
facebook-www/ReactFlightDOMRelayClient-dev.modern.js = 13.01 kB 10.77 kB = 3.82 kB 3.21 kB
facebook-www/ReactFlightDOMRelayClient-dev.classic.js = 13.01 kB 10.77 kB = 3.82 kB 3.21 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
facebook-www/ReactFlightDOMRelayServer-dev.modern.js = 55.03 kB 54.89 kB = 14.06 kB 14.05 kB
facebook-www/ReactFlightDOMRelayServer-dev.classic.js = 54.97 kB 54.84 kB = 14.04 kB 14.03 kB
facebook-react-native/react-is/cjs/ReactIs-dev.js = 7.71 kB 7.68 kB = 2.15 kB 2.15 kB
oss-experimental/react-is/cjs/react-is.development.js = 7.38 kB 7.35 kB = 2.02 kB 2.01 kB
oss-stable-semver/react-is/cjs/react-is.development.js = 7.36 kB 7.33 kB = 2.02 kB 2.01 kB
oss-stable/react-is/cjs/react-is.development.js = 7.36 kB 7.33 kB = 2.02 kB 2.01 kB
oss-experimental/react-is/umd/react-is.development.js = 7.94 kB 7.90 kB = 2.10 kB 2.09 kB
oss-stable-semver/react-is/umd/react-is.development.js = 7.91 kB 7.88 kB = 2.10 kB 2.09 kB
oss-stable/react-is/umd/react-is.development.js = 7.91 kB 7.88 kB = 2.10 kB 2.09 kB
facebook-react-native/react-is/cjs/ReactIs-prod.js = 4.80 kB 4.78 kB = 1.15 kB 1.15 kB
facebook-react-native/react-is/cjs/ReactIs-profiling.js = 4.80 kB 4.78 kB = 1.15 kB 1.15 kB
facebook-www/React-dev.classic.js = 119.12 kB 118.51 kB = 29.33 kB 29.26 kB
facebook-www/React-dev.modern.js = 118.03 kB 117.41 kB = 29.10 kB 29.03 kB
facebook-www/ReactDOMServerStreaming-prod.modern.js = 85.69 kB 85.14 kB = 17.93 kB 17.80 kB
facebook-www/ReactDOMServer-prod.modern.js = 81.70 kB 81.15 kB = 16.96 kB 16.84 kB
facebook-www/ReactDOMServer-prod.classic.js = 84.63 kB 84.00 kB = 17.58 kB 17.45 kB
facebook-www/ReactFlightDOMRelayServer-prod.modern.js = 28.20 kB 27.98 kB = 7.43 kB 7.37 kB
facebook-www/ReactFlightDOMRelayServer-prod.classic.js = 28.13 kB 27.90 kB = 7.40 kB 7.33 kB
facebook-www/JSXDEVRuntime-dev.classic.js = 46.29 kB 45.70 kB = 13.02 kB 12.94 kB
facebook-www/JSXDEVRuntime-dev.modern.js = 46.29 kB 45.70 kB = 13.01 kB 12.94 kB
facebook-www/ReactFlightDOMRelayClient-prod.classic.js = 6.34 kB 6.21 kB = 1.92 kB 1.87 kB
facebook-www/ReactFlightDOMRelayClient-prod.modern.js = 6.34 kB 6.21 kB = 1.92 kB 1.87 kB
facebook-www/React-profiling.modern.js = 20.16 kB 19.56 kB = 5.01 kB 4.89 kB
facebook-www/React-prod.modern.js = 19.55 kB 18.95 kB = 4.89 kB 4.76 kB
facebook-www/React-profiling.classic.js = 20.47 kB 19.85 kB = 5.10 kB 4.98 kB
facebook-www/React-prod.classic.js = 19.87 kB 19.24 kB = 4.98 kB 4.85 kB
facebook-www/ReactIs-dev.classic.js = 10.15 kB 9.62 kB = 2.61 kB 2.54 kB
facebook-www/ReactIs-dev.modern.js = 10.15 kB 9.62 kB = 2.61 kB 2.54 kB
facebook-www/ReactIs-prod.classic.js = 5.94 kB 5.35 kB = 1.45 kB 1.30 kB
facebook-www/ReactIs-prod.modern.js = 5.94 kB 5.35 kB = 1.45 kB 1.30 kB
facebook-www/ReactFreshRuntime-dev.modern.js = 23.00 kB 20.58 kB = 6.68 kB 6.02 kB
facebook-www/ReactFreshRuntime-dev.classic.js = 23.00 kB 20.58 kB = 6.68 kB 6.02 kB
facebook-www/JSXDEVRuntime-prod.classic.js = 0.49 kB 0.43 kB = 0.34 kB 0.30 kB
facebook-www/JSXDEVRuntime-prod.modern.js = 0.49 kB 0.43 kB = 0.34 kB 0.30 kB
facebook-www/JSXDEVRuntime-profiling.classic.js = 0.49 kB 0.43 kB = 0.34 kB 0.30 kB
facebook-www/JSXDEVRuntime-profiling.modern.js = 0.49 kB 0.43 kB = 0.34 kB 0.30 kB
facebook-www/ReactFlightDOMRelayClient-dev.modern.js = 13.01 kB 10.77 kB = 3.82 kB 3.21 kB
facebook-www/ReactFlightDOMRelayClient-dev.classic.js = 13.01 kB 10.77 kB = 3.82 kB 3.21 kB

Generated by 🚫 dangerJS against 8dede3e

@rickhanlonii rickhanlonii merged commit 0de3ddf into main Aug 25, 2022
@rickhanlonii rickhanlonii deleted the rh-rm-symbol-polyfill branch August 25, 2022 21:01
GrinZero added a commit to GrinZero/react that referenced this pull request Aug 31, 2022
* 'main' of ssh://github.com/GrinZero/react: (26 commits)
  [devtools][easy] Fix flow type (facebook#25147)
  Remove Symbol Polyfill (again) (facebook#25144)
  Remove ReactFiberFlags MountLayoutDev and MountPassiveDev (facebook#25091)
  experimental_use(promise) (facebook#25084)
  [Transition Tracing] onMarkerIncomplete - Tracing Marker/Suspense Boundary Deletions (facebook#24885)
  [Flight] Add support for Webpack Async Modules (facebook#25138)
  Fix typo: supportsMicrotask -> supportsMicrotasks (facebook#25142)
  Allow functions to be used as module references (facebook#25137)
  Test the node-register hooks in unit tests (facebook#25132)
  Return closestInstance in `getInspectorDataForViewAtPoint` (facebook#25118)
  [DevTools] Highlight RN elements on hover (facebook#25106)
  Update fixtures/flight to webpack 5 (facebook#25115)
  Align StrictMode behaviour with production (facebook#25049)
  Scaffolding for useMemoCache hook (facebook#25123)
  devtools: Fix typo from directores to directories (facebook#25124)
  fixture: Fix typo from perfomrance to performance (facebook#25100)
  [DevTools] Add events necessary for click to inspect on RN (facebook#25111)
  Add missing createServerContext for experimental shared subset (facebook#25114)
  support subresource integrity for bootstrapScripts and bootstrapModules (facebook#25104)
  make preamble and postamble types explicit and fix typo (facebook#25102)
  ...
facebook-github-bot pushed a commit to facebook/react-native that referenced this pull request Sep 12, 2022
Summary:
This sync includes the following changes:
- **[c28f313e6](facebook/react@c28f313e6 )**: experimental_use(promise) for SSR ([#25214](facebook/react#25214)) //<Andrew Clark>//
- **[d6f9628a8](facebook/react@d6f9628a8 )**: Remove some RSC subset entry points that were removed in the main entry point ([#25209](facebook/react#25209)) //<Sebastian Markbåge>//
- **[a473d08fc](facebook/react@a473d08fc )**: Update to Flow from 0.97 to 0.122 ([#25204](facebook/react#25204)) //<Jan Kassens>//
- **[7028ce745](facebook/react@7028ce745 )**: experimental_use(promise) for Server Components ([#25207](facebook/react#25207)) //<Andrew Clark>//
- **[bfb65681e](facebook/react@bfb65681e )**: experimental_use(context)([#25202](facebook/react#25202)) //<mofeiZ>//
- **[f0efa1164](facebook/react@f0efa1164 )**: [flow] remove custom suppress comment config ([#25170](facebook/react#25170)) //<Jan Kassens>//
- **[2e7f422fe](facebook/react@2e7f422fe )**: Refactor: its type is Container ([#25153](facebook/react#25153)) //<bubucuo>//
- **[2c2d9a1df](facebook/react@2c2d9a1df )**: [eslint-plugin-react-hooks] only allow capitalized component names ([#25162](facebook/react#25162)) //<Jan Kassens>//
- **[36c908a6c](facebook/react@36c908a6c )**: Don't use the Flight terminology in public error messages ([#25166](facebook/react#25166)) //<Sebastian Markbåge>//
- **[8d1b057ec](facebook/react@8d1b057ec )**: [Flight] Minor error handling fixes ([#25151](facebook/react#25151)) //<Sebastian Markbåge>//
- **[9ff738f53](facebook/react@9ff738f53 )**: [devtools][easy] Fix flow type ([#25147](facebook/react#25147)) //<Tianyu Yao>//
- **[0de3ddf56](facebook/react@0de3ddf56 )**: Remove Symbol Polyfill (again) ([#25144](facebook/react#25144)) //<Ricky>//
- **[b36f72235](facebook/react@b36f72235 )**: Remove ReactFiberFlags MountLayoutDev and MountPassiveDev ([#25091](facebook/react#25091)) //<Samuel Susla>//
- **[b6978bc38](facebook/react@b6978bc38 )**: experimental_use(promise) ([#25084](facebook/react#25084)) //<Andrew Clark>//
- **[11ed7010c](facebook/react@11ed7010c )**: [Transition Tracing] onMarkerIncomplete - Tracing Marker/Suspense Boundary Deletions ([#24885](facebook/react#24885)) //<Luna Ruan>//
- **[b79894259](facebook/react@b79894259 )**: [Flight] Add support for Webpack Async Modules ([#25138](facebook/react#25138)) //<Sebastian Markbåge>//
- **[c8b778b7f](facebook/react@c8b778b7f )**: Fix typo: supportsMicrotask -> supportsMicrotasks ([#25142](facebook/react#25142)) //<kwzr>//
- **[d0f396651](facebook/react@d0f396651 )**: Allow functions to be used as module references ([#25137](facebook/react#25137)) //<Sebastian Markbåge>//
- **[38c5d8a03](facebook/react@38c5d8a03 )**: Test the node-register hooks in unit tests ([#25132](facebook/react#25132)) //<Sebastian Markbåge>//
- **[3f70e68ce](facebook/react@3f70e68ce )**: Return closestInstance in `getInspectorDataForViewAtPoint` ([#25118](facebook/react#25118)) //<Tianyu Yao>//
- **[3d443cad7](facebook/react@3d443cad7 )**: Update fixtures/flight to webpack 5 ([#25115](facebook/react#25115)) //<Tim Neutkens>//
- **[5d1ce6513](facebook/react@5d1ce6513 )**: Align StrictMode behaviour with production ([#25049](facebook/react#25049)) //<Samuel Susla>//
- **[9e67e7a31](facebook/react@9e67e7a31 )**: Scaffolding for useMemoCache hook ([#25123](facebook/react#25123)) //<Joseph Savona>//
- **[19e9a4c68](facebook/react@19e9a4c68 )**: Add missing createServerContext for experimental shared subset ([#25114](facebook/react#25114)) //<Jiachi Liu>//
- **[6ef466c68](facebook/react@6ef466c68 )**: make preamble and postamble types explicit and fix typo ([#25102](facebook/react#25102)) //<Josh Story>//
- **[796d31809](facebook/react@796d31809 )**: Implement basic stylesheet Resources for react-dom ([#25060](facebook/react#25060)) //<Josh Story>//
- **[32baab38f](facebook/react@32baab38f )**: [Transition Tracing] Add Tag Field to Marker Instance ([#25085](facebook/react#25085)) //<Luna Ruan>//
- **[8ef3a7c08](facebook/react@8ef3a7c08 )**: Resume immediately pinged fiber without unwinding ([#25074](facebook/react#25074)) //<Andrew Clark>//
- **[7bcc68772](facebook/react@7bcc68772 )**: Remove argument committedLanes from reappearLayoutEffects and recursivelyTraverseReappearLayoutEffects ([#25080](facebook/react#25080)) //<Samuel Susla>//
- **[ca990e9a7](facebook/react@ca990e9a7 )**: Add API to force Scheduler to yield for macrotask ([#25044](facebook/react#25044)) //<Andrew Clark>//
- **[b4204ede6](facebook/react@b4204ede6 )**: Clean up unused Deletion flag ([#24992](facebook/react#24992)) //<Andrew Clark>//
- **[e193be87e](facebook/react@e193be87e )**: [Transition Tracing] Add Offscreen Test ([#25035](facebook/react#25035)) //<Luna Ruan>//
- **[9fcaf88d5](facebook/react@9fcaf88d5 )**: Remove rootContainerInstance from unnecessary places ([#25024](facebook/react#25024)) //<Sebastian Markbåge>//
- **[80f3d8819](facebook/react@80f3d8819 )**: Mount/unmount passive effects when Offscreen visibility changes ([#24977](facebook/react#24977)) //<Andrew Clark>//

Changelog:
[General][Changed] - React Native sync for revisions 4ea064e...c28f313

Reviewed By: rickhanlonii

Differential Revision: D39384898

fbshipit-source-id: 20b080a53851d6dd9d522c8468dd02aab9ba76db
rickhanlonii added a commit that referenced this pull request Oct 5, 2022
OlimpiaZurek pushed a commit to OlimpiaZurek/react-native that referenced this pull request May 22, 2023
Summary:
This sync includes the following changes:
- **[c28f313e6](facebook/react@c28f313e6 )**: experimental_use(promise) for SSR ([facebook#25214](facebook/react#25214)) //<Andrew Clark>//
- **[d6f9628a8](facebook/react@d6f9628a8 )**: Remove some RSC subset entry points that were removed in the main entry point ([facebook#25209](facebook/react#25209)) //<Sebastian Markbåge>//
- **[a473d08fc](facebook/react@a473d08fc )**: Update to Flow from 0.97 to 0.122 ([facebook#25204](facebook/react#25204)) //<Jan Kassens>//
- **[7028ce745](facebook/react@7028ce745 )**: experimental_use(promise) for Server Components ([facebook#25207](facebook/react#25207)) //<Andrew Clark>//
- **[bfb65681e](facebook/react@bfb65681e )**: experimental_use(context)([facebook#25202](facebook/react#25202)) //<mofeiZ>//
- **[f0efa1164](facebook/react@f0efa1164 )**: [flow] remove custom suppress comment config ([facebook#25170](facebook/react#25170)) //<Jan Kassens>//
- **[2e7f422fe](facebook/react@2e7f422fe )**: Refactor: its type is Container ([facebook#25153](facebook/react#25153)) //<bubucuo>//
- **[2c2d9a1df](facebook/react@2c2d9a1df )**: [eslint-plugin-react-hooks] only allow capitalized component names ([facebook#25162](facebook/react#25162)) //<Jan Kassens>//
- **[36c908a6c](facebook/react@36c908a6c )**: Don't use the Flight terminology in public error messages ([facebook#25166](facebook/react#25166)) //<Sebastian Markbåge>//
- **[8d1b057ec](facebook/react@8d1b057ec )**: [Flight] Minor error handling fixes ([facebook#25151](facebook/react#25151)) //<Sebastian Markbåge>//
- **[9ff738f53](facebook/react@9ff738f53 )**: [devtools][easy] Fix flow type ([facebook#25147](facebook/react#25147)) //<Tianyu Yao>//
- **[0de3ddf56](facebook/react@0de3ddf56 )**: Remove Symbol Polyfill (again) ([facebook#25144](facebook/react#25144)) //<Ricky>//
- **[b36f72235](facebook/react@b36f72235 )**: Remove ReactFiberFlags MountLayoutDev and MountPassiveDev ([facebook#25091](facebook/react#25091)) //<Samuel Susla>//
- **[b6978bc38](facebook/react@b6978bc38 )**: experimental_use(promise) ([facebook#25084](facebook/react#25084)) //<Andrew Clark>//
- **[11ed7010c](facebook/react@11ed7010c )**: [Transition Tracing] onMarkerIncomplete - Tracing Marker/Suspense Boundary Deletions ([facebook#24885](facebook/react#24885)) //<Luna Ruan>//
- **[b79894259](facebook/react@b79894259 )**: [Flight] Add support for Webpack Async Modules ([facebook#25138](facebook/react#25138)) //<Sebastian Markbåge>//
- **[c8b778b7f](facebook/react@c8b778b7f )**: Fix typo: supportsMicrotask -> supportsMicrotasks ([facebook#25142](facebook/react#25142)) //<kwzr>//
- **[d0f396651](facebook/react@d0f396651 )**: Allow functions to be used as module references ([facebook#25137](facebook/react#25137)) //<Sebastian Markbåge>//
- **[38c5d8a03](facebook/react@38c5d8a03 )**: Test the node-register hooks in unit tests ([facebook#25132](facebook/react#25132)) //<Sebastian Markbåge>//
- **[3f70e68ce](facebook/react@3f70e68ce )**: Return closestInstance in `getInspectorDataForViewAtPoint` ([facebook#25118](facebook/react#25118)) //<Tianyu Yao>//
- **[3d443cad7](facebook/react@3d443cad7 )**: Update fixtures/flight to webpack 5 ([facebook#25115](facebook/react#25115)) //<Tim Neutkens>//
- **[5d1ce6513](facebook/react@5d1ce6513 )**: Align StrictMode behaviour with production ([facebook#25049](facebook/react#25049)) //<Samuel Susla>//
- **[9e67e7a31](facebook/react@9e67e7a31 )**: Scaffolding for useMemoCache hook ([facebook#25123](facebook/react#25123)) //<Joseph Savona>//
- **[19e9a4c68](facebook/react@19e9a4c68 )**: Add missing createServerContext for experimental shared subset ([facebook#25114](facebook/react#25114)) //<Jiachi Liu>//
- **[6ef466c68](facebook/react@6ef466c68 )**: make preamble and postamble types explicit and fix typo ([facebook#25102](facebook/react#25102)) //<Josh Story>//
- **[796d31809](facebook/react@796d31809 )**: Implement basic stylesheet Resources for react-dom ([facebook#25060](facebook/react#25060)) //<Josh Story>//
- **[32baab38f](facebook/react@32baab38f )**: [Transition Tracing] Add Tag Field to Marker Instance ([facebook#25085](facebook/react#25085)) //<Luna Ruan>//
- **[8ef3a7c08](facebook/react@8ef3a7c08 )**: Resume immediately pinged fiber without unwinding ([facebook#25074](facebook/react#25074)) //<Andrew Clark>//
- **[7bcc68772](facebook/react@7bcc68772 )**: Remove argument committedLanes from reappearLayoutEffects and recursivelyTraverseReappearLayoutEffects ([facebook#25080](facebook/react#25080)) //<Samuel Susla>//
- **[ca990e9a7](facebook/react@ca990e9a7 )**: Add API to force Scheduler to yield for macrotask ([facebook#25044](facebook/react#25044)) //<Andrew Clark>//
- **[b4204ede6](facebook/react@b4204ede6 )**: Clean up unused Deletion flag ([facebook#24992](facebook/react#24992)) //<Andrew Clark>//
- **[e193be87e](facebook/react@e193be87e )**: [Transition Tracing] Add Offscreen Test ([facebook#25035](facebook/react#25035)) //<Luna Ruan>//
- **[9fcaf88d5](facebook/react@9fcaf88d5 )**: Remove rootContainerInstance from unnecessary places ([facebook#25024](facebook/react#25024)) //<Sebastian Markbåge>//
- **[80f3d8819](facebook/react@80f3d8819 )**: Mount/unmount passive effects when Offscreen visibility changes ([facebook#24977](facebook/react#24977)) //<Andrew Clark>//

Changelog:
[General][Changed] - React Native sync for revisions 4ea064e...c28f313

Reviewed By: rickhanlonii

Differential Revision: D39384898

fbshipit-source-id: 20b080a53851d6dd9d522c8468dd02aab9ba76db
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants