Handling FaissException in few destructors of ResultHandler.h #3311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: **Context** [Issue 2948](facebookresearch#2948) highlights potential issue of calling allocation on result handler which may throw exception but it is not handled. **In this diff**, I observed two calls where we may potentially call allocation in ResultHandler.h and handled FaissException. 1/ partial result when finalized in ~SingleResultHandler 2/ partial result when merged in ~RangeSearchBlockResultHandler Differential Revision: D55258213
|
This pull request was exported from Phabricator. Differential Revision: D55258213 |
|
This pull request has been merged in 798427c. |
abhinavdangeti
pushed a commit
to blevesearch/faiss
that referenced
this pull request
Jul 12, 2024
…okresearch#3311) Summary: Pull Request resolved: facebookresearch#3311 **Context** [Issue 2948](facebookresearch#2948) highlights potential issue of calling allocation on result handler which may throw exception but it is not handled. **In this diff**, I observed two calls where we may potentially call allocation in ResultHandler.h and handled FaissException. 1/ partial result when finalized in ~SingleResultHandler 2/ partial result when merged in ~RangeSearchBlockResultHandler Reviewed By: junjieqi Differential Revision: D55258213 fbshipit-source-id: 259be472e73619b2fcb0ea480d6d3486affeafdf
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Context
Issue 2948 highlights potential issue of calling allocation on result handler which may throw exception but it is not handled.
In this diff,
I observed two calls where we may potentially call allocation in ResultHandler.h and handled FaissException.
1/ partial result when finalized in ~SingleResultHandler
2/ partial result when merged in ~RangeSearchBlockResultHandler
Differential Revision: D55258213