Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Handling FaissException in few destructors of ResultHandler.h #3311

Closed
wants to merge 1 commit into from
Closed

Handling FaissException in few destructors of ResultHandler.h #3311

wants to merge 1 commit into from

Commits on Mar 22, 2024

  1. Handling FaissException in few destructors of ResultHandler.h 

    Summary:
**Context**
[Issue 2948](facebookresearch#2948) highlights potential issue of calling allocation on result handler which may throw exception but it is not handled.

**In this diff**,
I observed two calls where we may potentially call allocation in ResultHandler.h and handled FaissException.
1/ partial result when finalized in ~SingleResultHandler
2/ partial result when merged in ~RangeSearchBlockResultHandler

Differential Revision: D55258213
    @kuarora @facebook-github-bot
    kuarora authored and facebook-github-bot committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    84e0753 View commit details
    Browse the repository at this point in the history