Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix for AnnotatedSliceDataset #276

Merged
merged 2 commits into from
Oct 24, 2022
Merged

Fix for AnnotatedSliceDataset #276

merged 2 commits into from
Oct 24, 2022

Conversation

NikolasMorshuis
Copy link
Contributor

Fixes issue #275

If no annotation_version is provided, the latest version of the annotation data will be used.

Also, some rows in the annotation data have study_level == 'Yes' and do not provide x- and y-values, which lead to an error previously. This is solved by setting the x- and y-value to -1 in this case, similar to the case when no annotation is provided for the MRI-volume.

Copy link
Contributor

@mmuckley mmuckley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a great fix to me!

The formatter versions we use are here, just run those and re-commit to the PR and I'll merge as soon as everything passes.

@facebook-github-bot
Copy link

Hi @NikolasMorshuis!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Oct 24, 2022
@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@mmuckley mmuckley merged commit 21323a1 into facebookresearch:main Oct 24, 2022
@NikolasMorshuis NikolasMorshuis deleted the fix_annotated_slice_dataset branch October 25, 2022 12:01
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants