Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: export httpErrors #148

Merged
merged 2 commits into from
Oct 18, 2023
Merged

feat: export httpErrors #148

merged 2 commits into from
Oct 18, 2023

Conversation

arthurfiorette
Copy link
Contributor

@arthurfiorette arthurfiorette commented Oct 18, 2023

These errors already can be used with fastify.httpErrors, however, when writing util functions or functions that will endup inside a route call but are elsewhere, passing the fastify.httpErrors as parameters throughout multiple functions is bad. It is already exported from lib/httpErrors, this PR just add their types and the index.js httpErrors export.

Test for types and js were added.

Checklist

@arthurfiorette
Copy link
Contributor Author

Ready for review :)

Copy link
Contributor

@Uzlopak Uzlopak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Uzlopak Uzlopak merged commit c82e8e0 into fastify:master Oct 18, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants