Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

build(deps-dev): replace standard with neostandard #179

Merged
merged 7 commits into from
Dec 17, 2024
Merged

Conversation

Fdawgs
Copy link
Member

@Fdawgs Fdawgs commented Dec 8, 2024

See fastify/fastify-cors#340. This is a batch PR, so may have some issues. Please review changes.

@Fdawgs Fdawgs changed the title chore: add eslint.config.js build(deps-dev): replace standard with neostandard Dec 8, 2024
@Fdawgs
Copy link
Member Author

Fdawgs commented Dec 16, 2024

@arthurfiorette the line failing linting was added in #148 by yourself.
I'm still very amateur with TypeScript so could you give me a hand with this, please? Can this variable be renamed without impacting functionality?

@arthurfiorette
Copy link
Contributor

Sure! let me take a look at it

package.json Show resolved Hide resolved
Signed-off-by: Frazer Smith <frazer.dev@icloud.com>
@arthurfiorette
Copy link
Contributor

arthurfiorette commented Dec 16, 2024

This seems to be a parsing error from eslint, that's a valid alternative and also the most preferred one.

Its safe to rename.

lib/httpError.d.ts Show resolved Hide resolved
lib/httpError.d.ts Show resolved Hide resolved
Fdawgs and others added 3 commits December 17, 2024 07:55
Co-authored-by: Arthur Fiorette <47537704+arthurfiorette@users.noreply.github.com>
Signed-off-by: Frazer Smith <frazer.dev@icloud.com>
Co-authored-by: Arthur Fiorette <47537704+arthurfiorette@users.noreply.github.com>
Signed-off-by: Frazer Smith <frazer.dev@icloud.com>
@Fdawgs Fdawgs merged commit 8329e91 into master Dec 17, 2024
13 checks passed
@Fdawgs Fdawgs deleted the build/standard branch December 17, 2024 08:20
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants