fix(core): Do not throw missing method error for regular hook methods (…

…#2636)
feathersjs · May 17, 2022 · afe9a3b · afe9a3b
1 parent 06d03e9
commit afe9a3b
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/packages/feathers/src/hooks/regular.ts b/packages/feathers/src/hooks/regular.ts
@@ -142,7 +142,7 @@ const createMap = (input: RegularHookMap<any, any>, methods: string[]) => {
     const data = convertHookData(input[type]);
 
     Object.keys(data).forEach((method) => {
-      if (method !== 'all' && !methods.includes(method)) {
+      if (method !== 'all' && !methods.includes(method) && !defaultServiceMethods.includes(method)) {
         throw new Error(`'${method}' is not a valid hook method`);
       }
     });

diff --git a/packages/feathers/test/hooks/before.test.ts b/packages/feathers/test/hooks/before.test.ts
@@ -38,7 +38,9 @@ describe('`before` hooks', () => {
           return new Promise((_resolve, reject) => {
             reject(new Error('This did not work'));
           });
-        }
+        },
+
+        find: []
       }
     });
-Original file line number
+Diff line change
@@ Expand Up / @@ -38,7 +38,9 @@ describe('`before` hooks', () => { @@
               return new Promise((_resolve, reject) => {
                 reject(new Error('This did not work'));
               });
-            }
+            },
+            find: []
           }
         });
@@ Expand Down @@