Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix(core): Do not throw missing method error for regular hook methods #2636

Merged
merged 1 commit into from
May 17, 2022
Merged

fix(core): Do not throw missing method error for regular hook methods #2636

merged 1 commit into from
May 17, 2022

Conversation

daffl
Copy link
Member

@daffl daffl commented May 17, 2022

This is a regression with the regular hook registration format (e.g. { before: { find: [] } }). It should not throw an error in that case but instead just do nothing.

Closes feathersjs-ecosystem/feathers-mailer#31

@daffl daffl force-pushed the regular-default-methods branch from a2ce235 to 7b6f920 Compare May 17, 2022 22:08
@daffl daffl mentioned this pull request May 17, 2022
Closed
@daffl daffl merged commit afe9a3b into dove May 17, 2022
@daffl daffl deleted the regular-default-methods branch May 17, 2022 22:20
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

find hook for mailer service is missing
1 participant
@daffl