Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: paych: Print "waiting for confirmation.." #8823

Merged
merged 1 commit into from
Jun 8, 2022

Conversation

rjan90
Copy link
Contributor

@rjan90 rjan90 commented Jun 8, 2022

Prints an "waiting for confirmation.." when running lotus paych [fromAddress toAddress amount] to indicate that the command is waiting for the msg to be confirmed and not just hanging.

Related Issues

Resolves #4138

Proposed Changes

Add a "waiting for confirmation.." print to improve the UX a tiny bit.

Checklist

Before you mark the PR ready for review, please make sure that:

  • All commits have a clear commit message.
  • The PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs,perf, refactor, revert, style, test
    • area: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet, deps
  • This PR has tests for new functionality or change in behaviour
  • If new user-facing features are introduced, clear usage guidelines and / or documentation updates should be included in https://lotus.filecoin.io or Discussion Tutorials.
  • CI is green

Prints an "waiting for confirmation.." when running `lotus paych [fromAddress toAddress amount]` to indicate that the command is waiting for the msg to be confirmed and not just hanging.
@rjan90 rjan90 requested a review from a team as a code owner June 8, 2022 08:45
@arajasek
Copy link
Contributor

arajasek commented Jun 8, 2022

Nice!

@arajasek arajasek merged commit e3f1eb2 into master Jun 8, 2022
@arajasek arajasek deleted the fix/ux-paych-addfunds branch June 8, 2022 15:25
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lotus paych add-funds doesn't work
2 participants