[SCFD-4128] [SCFD-4126] feat(): Removed validation process for unit system conversion #666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
benflexcompute
commented
Jan 17, 2025
•
benflexcompute
commented
- feat(): Removed validation process for unit system conversion
- Change temperature unit for imperial to be Fahrenheit
benflexcompute
changed the title
angranl-flex
approved these changes
Jan 20, 2025
| @@ -58,6 +60,7 @@ | |||
| ) | |||
| from flow360.component.utils import remove_properties_by_name | |||
| from flow360.exceptions import Flow360TranslationError | |||
| from flow360.log import log | |||
There was a problem hiding this comment.
Should we remove this import since it is not used?
There was a problem hiding this comment.
Good catch, curse the pytlint disable. We should limit its scope from now on.
| def test_unit_system_conversion(): | ||
| with open("data/simulation_param.json", "r") as fp: | ||
| dict_to_convert = json.load(fp) | ||
| services.change_unit_system(data=dict_to_convert, new_unit_system="Imperial") |
There was a problem hiding this comment.
Do we also need to test the conversion to "CGS" and "SI"?
There was a problem hiding this comment.
Added to CGS conversion and SI conversion.
benflexcompute
force-pushed
the
BenY/NoValidationUnitConversion
branch
from
08d1a5b to
b754b83
Compare
Change temperature unit for imperial to be Fahrenheit Fixed bugs More tests
benflexcompute
force-pushed
the
BenY/NoValidationUnitConversion
branch
from
b754b83 to
f3d72c2
Compare
benflexcompute
added a commit
that referenced
this pull request
Jan 23, 2025
…ystem conversion (#666) * feat(): Removed validation process for unit system conversion Change temperature unit for imperial to be Fahrenheit Fixed bugs More tests * Ready to be reviewed * Fix lint * Fix lint * Corrected the SI unit test * Fix fragial windows float computation
benflexcompute
added a commit
that referenced
this pull request
Jan 23, 2025
…use they are not tested yet and I need to deploy a new version. (#684) * Revert "fix(): Ammend bugs in PR#668, also changed Imperial unit system to use Fahrenheit as default temperature unit (#678) (#680)" This reverts commit 160062e. * Revert "[SCFD-4128] [SCFD-4126] feat(): Removed validation process for unit system conversion (#666) (#679)" This reverts commit 2568a16. * Revert "fix(): temperature_offset has same unit conversion as temperature (#668) (#677)" This reverts commit 07b91cc. * Hacy fix to diable the positive temperature check.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.