[HOTFIX] fix(): Amend bugs in PR#668, also changed Imperial unit system to use Fahrenheit as default temperature unit (#678) #680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e Fahrenheit as default temperature unit (#678) * fix(): Ammend bugs in PR#668, also changed Imperial unit system to use Fahrenheit as default temperature unit * Fix V1 unit test
benflexcompute
added a commit
that referenced
this pull request
Jan 23, 2025
…use they are not tested yet and I need to deploy a new version. (#684) * Revert "fix(): Ammend bugs in PR#668, also changed Imperial unit system to use Fahrenheit as default temperature unit (#678) (#680)" This reverts commit 160062e. * Revert "[SCFD-4128] [SCFD-4126] feat(): Removed validation process for unit system conversion (#666) (#679)" This reverts commit 2568a16. * Revert "fix(): temperature_offset has same unit conversion as temperature (#668) (#677)" This reverts commit 07b91cc. * Hacy fix to diable the positive temperature check.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…
fix(): Ammend bugs in PR#668, also changed Imperial unit system to use Fahrenheit as default temperature unit
Fix V1 unit test