[Placeholder] Respect a possible 'image icon' not occupying the same space #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ame space as a real image should
lubber-de
added
lang/css
lubber-de
removed
the
state/awaiting-reviews
This was referenced Dec 21, 2018
Merged
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
An image icon withing a placeholder was handled as a normal
imagegaining the wrong height.Testcase
https://jsfiddle.net/70q5er49/1/
Change
imageto for examplepdfto see the current behaviorScreenshot
Before
After
Closes
Semantic-Org/Semantic-UI#6671