Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[Dropdown] Filter already selected items when using remote api as datastore #287

Merged
merged 1 commit into from
Dec 5, 2018
Merged

[Dropdown] Filter already selected items when using remote api as datastore #287

merged 1 commit into from
Dec 5, 2018

Conversation

lubber-de
Copy link
Member

@lubber-de lubber-de commented Dec 4, 2018 •
edited
Loading

Description

When the remoteApi was used in a dropdown to retrieve the items according to some searchterm, the list of items was always renewed, but already selected items from the previous list where not filtered again, so they appeared again.

Testcase

  • Click the dropdown and select anything you want
  • close the drop down, reopen it by clicking into it again

Unfixed

Fixed

Closes

Semantic-Org/Semantic-UI#6388
Semantic-Org/Semantic-UI#5566

@lubber-de lubber-de added type/bug Any issue which is a bug or PR which fixes a bug lang/javascript Anything involving JavaScript state/awaiting-reviews Pull requests which are waiting for reviews labels Dec 4, 2018
@lubber-de lubber-de added this to the 2.7.x milestone Dec 4, 2018
y0hami
y0hami approved these changes Dec 4, 2018
View reviewed changes
Copy link
Member

@y0hami y0hami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lubber-de lubber-de added the tag/sui-issue Taken from an existing Issue/PR of SUI label Dec 4, 2018
prudho
prudho approved these changes Dec 5, 2018
View reviewed changes
Copy link
Contributor

@prudho prudho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@y0hami y0hami merged commit f979cfb into fomantic:develop Dec 5, 2018
@y0hami y0hami removed the state/awaiting-reviews Pull requests which are waiting for reviews label Dec 5, 2018
@lubber-de lubber-de deleted the fix/6388/dropdown_remoteapi_refilter_items branch December 5, 2018 11:20
@lubber-de lubber-de modified the milestones: 2.7.x, 2.7.0 Dec 5, 2018
lubber-de added a commit to lubber-de/Fomantic-UI that referenced this pull request Dec 11, 2018
@lubber-de
fix(dropdown): Make fomantic#287 also work for div-dropdowns and prev…
70c6006 
…ent console error
@lubber-de lubber-de mentioned this pull request Dec 11, 2018
Merged
y0hami pushed a commit that referenced this pull request Dec 13, 2018
@lubber-de
fix(dropdown): filter preselected entries from #287 was not working f…
26b3875 
…or div-dropdowns
y0hami pushed a commit that referenced this pull request Dec 18, 2018
@lubber-de
fix(dropdown): filter preselected entries from #287 was not working f…
16f6f3a 
…or div-dropdowns
This was referenced Dec 21, 2018
Merged
Merged
y0hami pushed a commit that referenced this pull request Dec 21, 2018
@lubber-de
fix(dropdown): filter preselected entries from #287 was not working f…
fc000b7 
…or div-dropdowns
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@y0hami y0hami y0hami approved these changes

@prudho prudho prudho approved these changes

@ColinFrick ColinFrick Awaiting requested review from ColinFrick

Assignees
No one assigned
Labels
lang/javascript Anything involving JavaScript tag/sui-issue Taken from an existing Issue/PR of SUI type/bug Any issue which is a bug or PR which fixes a bug
Projects
None yet
Milestone
2.7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@lubber-de @prudho @y0hami