[DropDown] Filter Preselected entries from #287 was not working for div-dropdowns #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ent console error
lubber-de
added
priority/high
ColinFrick
approved these changes
Dec 13, 2018
y0hami
removed
state/awaiting-reviews
exoego
added
type/bug
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The PR #287 to filter remote dropdown values with already preselected values was broken when the dropdown was initiated out of a div-tag and resulted in console error, because those dropdowns use input-fields, thus strings for storing selections. Select-fields, which was used in the PR, stored value are retrieved as arrays where it was working before.
This PR now takes care of that and always generates an array, making the functionality work for all types of dropdowns now.
Fixes
#287