Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update dependency fourseven:scss #10825

Merged
merged 2 commits into from
Dec 28, 2017
Merged

Update dependency fourseven:scss #10825

merged 2 commits into from
Dec 28, 2017

Conversation

raym
Copy link
Contributor

@raym raym commented Dec 28, 2017

Fixes #10606 by updating the version of fourseven:scss implied in package.js.

Also fixed a syntax error that was throwing an error when including this into a meteor project:

=> Started proxy.                             
=> Errors prevented startup:                  
   
   While processing files with ecmascript (for target web.browser):
   <anonymous>: .babelrc is not a valid JSON file: Unexpected token ] in JSON at position 356
   at JSON.parse (<anonymous>)
   at BabelCompiler.BCp._inferFromBabelRc (packages/babel-compiler.js:255:16)
   at BabelCompiler.BCp.inferExtraBabelOptions (packages/babel-compiler.js:244:10)
   at BabelCompiler.BCp.processOneFileForTarget (packages/babel-compiler.js:174:10)
   at BabelCompiler.<anonymous> (packages/babel-compiler.js:111:26)
   at Array.forEach (<anonymous>)
   at BabelCompiler.BCp.processFilesForTarget (packages/babel-compiler.js:110:14)

I also noted that Node 8 was required to get this running properly, which I was unaware of but is probably common knowledge.

@ncoden
Copy link
Contributor

ncoden commented Dec 28, 2017

Thank you @raym

ncoden pushed a commit to ncoden/foundation-sites that referenced this pull request Jun 16, 2018
244a684 update version of `fourseven:scss` dependency
821e478 remove comma after last element in array. was throwing syntax error

Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>
@ncoden
Copy link
Contributor

ncoden commented Jun 21, 2018

Actually, this introduced an issue: Foundation is considered as compatible anymore with older Meteor versions (but it should be).

I think we can use the following version range instead:

fourseven:scss@3.4.1 || 4.0.0

I lost a lot of time searching for this "version range" thing in Meteor so I hope this will works. The Atmosphere ecosystem has serious issues with compatibility management compared to npm.

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong version for meteor + wrong dependancy for fourseven:scss
2 participants