fix: revise Meteor "fourseven:scss" compatibility for Meteor<1.4.1 support #11349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…upport Foundation support all `fourseven:scss` versions from `v3.4`. Changes: * revise `fourseven:scss` compatibility to `3.4.1 || 4.0.0` to support both older and newer Meteor versions
DanielRuf
reviewed
Jun 22, 2018
| @@ -8,8 +8,8 @@ Package.describe({ | |||
|
|
|||
| Package.onUse(function(api) { | |||
| api.versionsFrom('1.2.1'); | |||
| api.imply('fourseven:scss@4.5.4'); | |||
| api.use(['ecmascript', 'jquery', 'fourseven:scss@4.5.4'], 'client'); | |||
| api.imply('fourseven:scss@3.4.1 || 4.0.0'); | |||
There was a problem hiding this comment.
I do not yet understand this range. Which versions does this target? 4.0.0 and 3.4.1?
There was a problem hiding this comment.
fourseven:scss@4.5 is only compatible with Meteor >= v1.4.1. See https://github.com/fourseven/meteor-scss. Using 3.4.1 || 4.0.0 tell Meteor to choose the version he want >=3.4.1 (minor and patch versions are automatically considered as compatible), which will be compatible with the client Meteor version (>=1.2.1).
There was a problem hiding this comment.
Ah ok, so >= is implied then.
There was a problem hiding this comment.
Yes. 3.4.1 || 4.0.0 means >=3.4.1 <5.0.0
DanielRuf
approved these changes
Jun 22, 2018
ncoden
added a commit
to ncoden/foundation-sites
that referenced
this pull request
Jun 23, 2018
…ss-compatibility for v6.5.0 009b469 fix: revise Meteor "fourseven:scss" compatibility for better Meteor support Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Revise
fourseven:scsscompatibility to3.4.1 || 4.0.0to support older and newer Meteor versions.Motivation and Context
Foundation supports a large range of versions for
fourseven:scss(fromv3.4) and Meteor (fromv1.2.1). Meteor packages version resolution will use all newer minor and patch versions but not major versions.As
fourseven:scssversions require a particular Meteor versions, the latest releases were considered as incompatible with Foundation. This was resported in #10606 andfourseven:scsswas updated in #10825 to resolve this. However, this only moved the issue as Foundation is now considered as incompatible with older Meteor versions.This pull request ensure that the Foundation actual compatibility with Meteor and its packages matches the compatibility allowed by Meteor package management.
Types of changes
functionality to change)
Checklist (all required):
developorsupport/*).I have updated the documentation accordingly to my changes (if relevant).I have added tests to cover my changes (if relevant).