Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: revise Meteor "fourseven:scss" compatibility for Meteor<1.4.1 support #11349

Merged
merged 1 commit into from
Jun 23, 2018
Merged

fix: revise Meteor "fourseven:scss" compatibility for Meteor<1.4.1 support #11349

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions package.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@ Package.describe({

Package.onUse(function(api) {
api.versionsFrom('1.2.1');
api.imply('fourseven:scss@4.5.4');
api.use(['ecmascript', 'jquery', 'fourseven:scss@4.5.4'], 'client');
api.imply('fourseven:scss@3.4.1 || 4.0.0');
Copy link
Contributor

@DanielRuf DanielRuf Jun 22, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not yet understand this range. Which versions does this target? 4.0.0 and 3.4.1?

Copy link
Contributor Author

@ncoden ncoden Jun 22, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fourseven:scss@4.5 is only compatible with Meteor >= v1.4.1. See https://github.com/fourseven/meteor-scss. Using 3.4.1 || 4.0.0 tell Meteor to choose the version he want >=3.4.1 (minor and patch versions are automatically considered as compatible), which will be compatible with the client Meteor version (>=1.2.1).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah ok, so >= is implied then.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. 3.4.1 || 4.0.0 means >=3.4.1 <5.0.0

api.use(['ecmascript', 'jquery', 'fourseven:scss@3.4.1 || 4.0.0'], 'client');
api.addFiles('dist/js/foundation.js', 'client');
api.addFiles([

Expand Down