Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Replace deprecated @elseif for @else if #11379

Merged
merged 1 commit into from
Jul 4, 2018
Merged

Replace deprecated @elseif for @else if #11379

merged 1 commit into from
Jul 4, 2018

Conversation

jblandry
Copy link
Contributor

@jblandry jblandry commented Jul 3, 2018 •
edited
Loading

Description

Replace the deprecated @elseif to @else if

Motivation and Context

DEPRECATION WARNING from compiler (dart-sass now being the official compiler)

https://github.com/sass/dart-sass/blob/master/lib/src/parse/scss.dart#L47

Types of changes

  • Documentation
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing
    functionality to change)

Checklist (all required):

  • I have read and follow the CONTRIBUTING document.
  • There are no other pull request similar to this one.
  • The pull request title is descriptive.
  • The template is fully and correctly filled.
  • The pull request targets the right branch (develop or support/*).
  • My commits are correctly titled and contain all relevant information.
  • My code follows the code style of this project.
  • I have updated the documentation accordingly to my changes (if relevant).
  • I have added tests to cover my changes (if relevant).
  • All new and existing tests passed.

ncoden
ncoden approved these changes Jul 3, 2018
View reviewed changes
Copy link
Contributor

@ncoden ncoden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jblandry. Thank you for the PR!
LGTM 👍

@ncoden ncoden added this to the 6.5.0 milestone Jul 3, 2018
@jblandry
Copy link
Contributor Author

jblandry commented Jul 4, 2018

Thx

@ncoden ncoden merged commit dfae54d into foundation:support/6.5 Jul 4, 2018
ncoden added a commit to ncoden/foundation-sites that referenced this pull request Jul 5, 2018
@ncoden
Merge pull request foundation#11379 from absolunet/fix-elseif
8f39562 
Replace deprecated `@elseif` for `@else if`
ncoden pushed a commit to ncoden/foundation-sites that referenced this pull request Jul 6, 2018
@jblandry @ncoden
Use pull request foundation#11379 from absolunet/fix-elseif for v6.5.0
5485900 
28c348b Replace deprecated `@elseif` for `@else if`

Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>
ncoden pushed a commit to ncoden/foundation-sites that referenced this pull request Jul 8, 2018
@jblandry @ncoden
Use pull request foundation#11379 from absolunet/fix-elseif for v6.5.0
78f315b 
28c348b Replace deprecated `@elseif` for `@else if`

Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>
@ncoden ncoden mentioned this pull request Jul 8, 2018
Merged
10 tasks
This was referenced Apr 22, 2020
Open
Open
Merged
Open
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@ncoden ncoden ncoden approved these changes

Assignees
No one assigned
Labels
bug fix scss
Projects
None yet
Milestone
6.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jblandry @ncoden