🚀 Release v6.5.0-rc.2 #11391
Merged
🚀 Release v6.5.0-rc.2 #11391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: resolve invalid conflict resolution foundation#11077 for v6.5
…-against-cve for v6.5.0 26f0ce5 chore: resolve jQuery devDependency CVE Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>
…side-of-breakpoint for v6.5.0 a4cac3f fix: remove $-zf-size from non-responsive XY Grid classes generation Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>
…4 for v6.5.0 a43e20b fix: fix Bower file invalid JSON foundation#11364 Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>
…ore-unbind-11360 for v6.5.0 2c8485f fix: prevent removing all listeners by checking them before unbinding Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>
…-checking-undefined-11363 for v6.5.0 dd493bd style: use typeof for checking undefined Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>
…6.5.0 1131937 Use correct data attribute for responsive toggle with animation Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>
…ltiple-completion-callback for v6.5.0 6cb8733 fix: fix completion callback called too many time in deploy task 9a9f0c1 style: remove unused "done" in "dist:deploy" gulp task dcd3ab8 fix: remove run-sequence from gulp `deploy:dist` task to detect its end Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>
0ec2be1 Define dropdown menu background in foundation-dropdown-menu mixin Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>
28c348b Replace deprecated `@elseif` for `@else if` Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>
…ery for v6.5.0 ff1c302 fix: initialize MediaQuery in global Foundation entry Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>
ncoden
requested review from
DanielRuf,
gakimball,
kball,
abdullahsalem,
DaSchTour,
rafibomb and
SassNinja
|
It's really hard to review such changes, I there are so many generate files in git and such many changes that just are rc.1 -> rc.2 so you don't really find the things to look at. |
|
@DaSchTour As a release PR contains all the release changes and distribution files, it is often not intended to be manually reviewed. Only the list of commit and changelog really matters here. |
DanielRuf
approved these changes
Jul 10, 2018
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Foundation v6.5.0 Release Candidate 2
This release provide additional bug fixes and various patches to improve the stability of Foundation.
Note about this pull request
As this version was built to have the best compatibility with
v6.4.4-rc1, we used a dedicated branch and manually picked safe changes from the development branchdevelop, excluding API evolutions and breaking changes. These imported changes are theUse pull request #xxxcommits you can see in this pull request. Development will continue ondevelopand will lead to a future release with all changes, including new features and breaking changes.Release Checklist
Update SCSS settings file▾
▾
Prepare release for MeteorDo not support pre-releases.versions▾
Changes from v6.5.0-rc.1
Components
🐛 #11104 - Fix radius on Input Group labels and buttons (@andycochran, #8833)
🐛 #11361 - Fix invalid gutters for vertical XY Grid auto/shrink cells (@ncoden, #11359)
🐛 #11366 - Fix window event listeners being removed in various components (@ncoden, #11360)
🐛 #11381 - Provide global Foundation.MediaQuery initialized (@ncoden, #10363)
Internal
🐛 #11350 - Fix and update Bower configuration (@ncoden)
🐛 #11356 - Resolve invalid conflict resolution #11077 (@DanielRuf, #11355)
🐛 #11367 - Fix invalid JSON in Bower package configuration (@ncoden, #11364)
🚚 #11346 - Fix completion callback called too many time in Gulp deploy task (@ncoden)
💻 #11351 - Resolve jQuery devDependency CVE (@ncoden)
📦 #11389 - Update dependencies (2018-07-06) and migrate to Gulp v4 (@ncoden)
💎 #11368 - Always use typeof for checking undefined values (@DanielRuf, #11363)
💎 #11379 - Use
@else ifinstead of deprecated@elseif(@jblandry)Documentation
📖 #11373 - Fix
data-animateattribute in Responsive Toggle documentation (@rlhawk, #11372)📖 #11377 - Fix ignored Dropdown Menu
$dropdownmenu-backgroundsetting (@rlhawk, #11376)📖 #11378 - Improve GitFlow model for supported versions (@ncoden)
📖 #11382 - Add a notice about required CSS in Media Query documentation (@ncoden, #11374)
Contributors