Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Use DotNet.ReproducibleBuilds #174

Merged
merged 3 commits into from
Dec 13, 2023
Merged

Use DotNet.ReproducibleBuilds #174

merged 3 commits into from
Dec 13, 2023

Conversation

bartelink
Copy link
Member

@bartelink bartelink commented May 28, 2022 •
edited
Loading

  • Replace SourceLink with DotNet.ReproducibleBuilds (enables removing many settings)

@bartelink bartelink force-pushed the reproducible-builds branch 3 times, most recently from 692ace4 to e1663a4 Compare May 28, 2022 14:37
@bartelink
Copy link
Member Author

bartelink commented May 28, 2022 •
edited
Loading

https://nuget.info/packages/Argu/6.1.1 suggests the sourcelink info is fine
My repro is to try to jump to source for arbitrary attributes, which is triggering a decompile, which does not happen for other libs I manage in github.com/jet

@bartelink bartelink force-pushed the reproducible-builds branch 3 times, most recently from f0fe231 to 64c5666 Compare May 28, 2022 15:09
@bartelink bartelink changed the title SDK 6, ReproducibleBuilds Infra update May 28, 2022
@bartelink bartelink force-pushed the reproducible-builds branch from 19a1f91 to f7a8b06 Compare May 28, 2022 15:21
@bartelink bartelink force-pushed the reproducible-builds branch 2 times, most recently from 1091c3f to 5796729 Compare November 28, 2023 11:11
@bartelink bartelink changed the title Infra update Use DotNet.ReproducibleBuilds Nov 28, 2023
@bartelink bartelink force-pushed the reproducible-builds branch 2 times, most recently from 795ca8d to 69babe5 Compare November 28, 2023 11:19
@bartelink bartelink mentioned this pull request Dec 12, 2023
Closed
@nojaf nojaf mentioned this pull request Dec 12, 2023
Merged
@bartelink bartelink mentioned this pull request Dec 13, 2023
Merged
@bartelink
Copy link
Member Author

As you can see I turned on requirements for comments to be resolved prior to merge
I also discovered the Linear history option - which would rule out merge commits but enable us to (selectively) do rebase merges.
I prefer to not think about that and only do squash merges, but feel free to flip "rebase merges" back on...

@nojaf nojaf merged commit b6893ea into fsprojects:master Dec 13, 2023
4 checks passed
@nojaf
Copy link
Collaborator

nojaf commented Dec 13, 2023

Ok, no strong opinion on this yet.

@bartelink bartelink deleted the reproducible-builds branch December 13, 2023 14:20
@bartelink
Copy link
Member Author

@nojaf looks like it worked per https://nuget.info/packages/Argu/6.1.3
image

bartelink added a commit to bartelink/Argu that referenced this pull request Feb 19, 2024
@bartelink
Use DotNet.ReproducibleBuilds (fsprojects#174)
4a983a6 
* DotNet.ReproducibleBuilds

* Remove packages.config

* Reinstate RepositoryUrl
bartelink added a commit to bartelink/Argu that referenced this pull request Feb 28, 2024
@bartelink
Use DotNet.ReproducibleBuilds (fsprojects#174)
c3227a6 
* DotNet.ReproducibleBuilds

* Remove packages.config

* Reinstate RepositoryUrl
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@nojaf nojaf nojaf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bartelink @nojaf