Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(Release): Inhibit packing of LS sample #201

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

bartelink
Copy link
Member

@bartelink bartelink commented Dec 13, 2023

Sets IsPackable to false for the LS sample
In order to inhibit production of a .nupkg for it (which the NuGet push action then proceeds to [attempt to] push)

re #189 (comment)

To avoid it being nuget pushed in a release
@bartelink
Copy link
Member Author

@nojaf local testing shows a build.sh -t Release now stops generating a nupkg for the LS sample exe
Let me know if you want me to slip this change into #174 instead

@bartelink bartelink mentioned this pull request Dec 13, 2023
@bartelink bartelink changed the title fix: Inhibit packing of LS sample fix(Release): Inhibit packing of LS sample Dec 13, 2023
@nojaf nojaf merged commit 28d768f into fsprojects:master Dec 13, 2023
4 checks passed
@bartelink bartelink deleted the nopack branch December 13, 2023 14:31
bartelink added a commit to bartelink/Argu that referenced this pull request Feb 19, 2024
To avoid it being nuget pushed in a release
bartelink added a commit to bartelink/Argu that referenced this pull request Feb 28, 2024
To avoid it being nuget pushed in a release
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants