pass filename to <ErrorReporter/> #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaearon
added a commit
that referenced
this pull request
Sep 15, 2015
pass filename to <ErrorReporter/>
|
Seems like there can be really nice applications to this, like opening in editor: commissure/redbox-react#10 (comment) |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in jedwards1211/meteor-webpack-react#40 (comment), the stack trace
redbox-reactprints doesn't have source maps applied whendevtoolis'source-map'.console.error(error.stack)prints out the original file names and locations from the source map; I'm not yet sure if it uses something special thaterror-stack-parsercould easily call, butreact-transform-catch-errorscan at least pass the filename to theErrorHandler.