We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Bug description
How to reproduce
Create tags that doesn't start with v. i.e. 0.0.1, 1.0.0, 1.0, etc.
v
0.0.1
1.0.0
1.0
git tag --list
1 1.2 1.2.3 11.11.11 2,2,2 v0HELLO v1 v1.2 v1.2.3 v11.11.11 x1.0.0
Current
git tag --list | grep v[0-9]*
v0HELLO v1 v1.2 v1.2.3 v11.11.11
Expected behavior
git tag --list | grep '^v\?[0-9]\+\(\.[0-9]\+\)\?\(\.[0-9]\+\)\?$'
1 1.2 1.2.3 11.11.11 v1 v1.2 v1.2.3 v11.11.11
- input: Buffer.from('git tag --list --merged HEAD | grep v[0-9]* | wc -l'), + input: Buffer.from('git tag --list --merged HEAD | grep '^v\?[0-9]\+\(\.[0-9]\+\)\?\(\.[0-9]\+\)\?$' | wc -l'),
Or more permissive:
git tag --list | grep '^v\?[0-9]\+'
1 1.2 1.2.3 11.11.11 2,2,2 v0HELLO v1 v1.2 v1.2.3 v11.11.11
- input: Buffer.from('git tag --list --merged HEAD | grep v[0-9]* | wc -l'), + input: Buffer.from('git tag --list --merged HEAD | grep '^v\?[0-9]\+' | wc -l'),
The text was updated successfully, but these errors were encountered:
Related code: https://github.com/game-ci/unity-builder/blob/main/src/model/versioning.ts https://github.com/game-ci/unity-builder/blob/main/src/model/versioning.test.ts
Sorry, something went wrong.
Fixes #242
4838df6
Support version tags that don't start with v for semantic versioning (#…
c45cd78
…303) * Fixes #242 * Update semver version * Update husky * Update husky pre-commit hook * Update dependencies * Update dependencies * Remove git add since changes will be automatically added * Restore git add * Update dependencies * Update test
Successfully merging a pull request may close this issue.
Bug description
How to reproduce
Create tags that doesn't start with
v
. i.e.0.0.1
,1.0.0
,1.0
, etc.Current
Expected behavior
Or more permissive:
The text was updated successfully, but these errors were encountered: