Support version tags that don't start with v for semantic versioning

[davidmfinol]

Changes

Fixes #242

Checklist

• Read the contribution guide and accept the code of conduct
• Readme (updated or not needed)
• Tests (added, updated or not needed)

[github-actions]

[codecov-commenter]

Codecov Report

Merging #303 (b482855) into main (a3e783f) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #303   +/-   ##
=======================================
  Coverage   56.72%   56.72%           
=======================================
  Files          23       23           
  Lines         781      781           
  Branches      158      145   -13     
=======================================
  Hits          443      443           
  Misses        337      337           
  Partials        1        1           

Impacted Files	Coverage Δ
src/model/versioning.ts	93.96% <100.00%> (ø)

[GabLeRoux]

I totally agree with this. According to https://semver.org/ prefixing with v isn't considered semantic so allowing versions without it should definitely be considered 😅

Is “v1.2.3” a semantic version?

No, “v1.2.3” is not a semantic version. However, prefixing a semantic version with a “v” is a common way (in English) to indicate it is a version number. Abbreviating “version” as “v” is often seen with version control. Example: git tag v1.2.3 -m "Release version 1.2.3", in which case “v1.2.3” is a tag name and the semantic version is “1.2.3”.

[webbertakken]

I totally agree with this. According to https://semver.org/ prefixing with v isn't considered semantic so allowing versions without it should definitely be considered 😅

Is “v1.2.3” a semantic version?
No, “v1.2.3” is not a semantic version. However, prefixing a semantic version with a “v” is a common way (in English) to indicate it is a version number. Abbreviating “version” as “v” is often seen with version control. Example: git tag v1.2.3 -m "Release version 1.2.3", in which case “v1.2.3” is a tag name and the semantic version is “1.2.3”.

While I agree we should support this, the v is not specific to semantic versioning and not part of the semantic version itself. It is GitHub convention to use v in the tag to indicate it's a version tag.

[webbertakken]

Suggest adding a separate tests for it('accepts valid semantic versions without v-prefix', () => {})

[davidmfinol]

Done

[webbertakken]

Two more things:

• Would you mind updating semver-regex as part of this PR?
  
• Could you please use descriptive PR titles, so that the releases properly show what changed (without manual work). See description generator: https://takken.io/tools

[davidmfinol]

• Would you mind updating semver-regex as part of this PR?

I didn't want to manually update the yarn.lock file, so I found that the semver-regex dependency came from husky, and I updated the versions of husky and lint-staged. The semver-regex dependency is now gone.

• Could you please use descriptive PR titles, so that the releases properly show what changed (without manual work). See description generator: https://takken.io/tools

I was hoping that the name would come from the linked issue, but I guess it doesn't do that. I've updated the title.

[webbertakken]

what does this do exactly? autogenerated?

[davidmfinol]

Yeah, it's auto-generated. The .husky/_ folder seems to be generated during the pre-commit check as a temporary workspace