feat: compatibility with self-hosted runners with SELinux #355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using a self-hosted runner with SELinux (fedora) volumes need to be mounted with ":z" in order to have write access these flags are documented [here](https://docs.docker.com/storage/bind-mounts/#configure-the-selinux-label)
|
|
src/model/docker.ts
Outdated
Comment on lines
47
to
50
| const github_home = join(runnerTemporaryPath, "_github_home"); | ||
| existsSync(github_home) || mkdirSync(github_home); | ||
| const github_workflow = join(runnerTemporaryPath, "_github_workflow"); | ||
| existsSync(github_workflow) || mkdirSync(github_workflow); |
There was a problem hiding this comment.
I believe these directories should exist according to the spec. Could you explain a little bit about why this is needed?
Also prefer the more semantic if(condition) // do something over || which makes the code harder to read for new developers
There was a problem hiding this comment.
They do exist in github runners, but when running in self-hosted runners, the _temp folder is completely empty.
I get this error:
Error: statfs /var/github/_temp/_github_home: no such file or directory
Error: The process '/usr/bin/docker' failed with exit code 125
I worked around the problem by doing this in my workflow:
# this is a workaround for self hosted runners
- name: Create Folders
run: |
cd $RUNNER_TEMP
mkdir -p _github_home
mkdir -p _github_workflow
- uses: game-ci/unity-builder@v2
env:
UNITY_LICENSE: ${{ secrets.UNITY_LICENSE }}
UNITY_EMAIL: ${{ secrets.UNITY_EMAIL }}
UNITY_PASSWORD: ${{ secrets.UNITY_PASSWORD }}
with:
targetPlatform: StandaloneLinux64
buildMethod: com.mindblocks.build.BuildAutomation.LinuxServer
and that worked.
I will change them to if
|
Could you run Also make sure you install ESLint and Prettier plugins in your editor. |
paulpach
added a commit
to paulpach/unity-test-runner
that referenced
this pull request
Mar 11, 2022
similar to game-ci/unity-builder#355 * Use $RUNNER_TEMP variable instead of hardcoded path for _github_home and _github_workflow * create the folders if they don't exist * mount volumes with :z for compatibility with SELinux
3 tasks
paulpach
added a commit
to paulpach/unity-test-runner
that referenced
this pull request
Mar 11, 2022
similar to game-ci/unity-builder#355 * Use $RUNNER_TEMP variable instead of hardcoded path for _github_home and _github_workflow * create the folders if they don't exist * mount volumes with :z for compatibility with SELinux
|
Thank you very much! |
webbertakken
pushed a commit
to game-ci/unity-test-runner
that referenced
this pull request
Mar 11, 2022
* feat: support self-hosted runners similar to game-ci/unity-builder#355 * Use $RUNNER_TEMP variable instead of hardcoded path for _github_home and _github_workflow * create the folders if they don't exist * mount volumes with :z for compatibility with SELinux * compile typescript files
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using a self-hosted runner with SELinux (fedora)
volumes need to be mounted with ":z" in order to have write access
these flags are documented here
Also the in self-hosted runners, _temp is empty, so this creates the child folders.
Changes
Checklist