feat: support self-hosted runners #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
similar to game-ci/unity-builder#355 * Use $RUNNER_TEMP variable instead of hardcoded path for _github_home and _github_workflow * create the folders if they don't exist * mount volumes with :z for compatibility with SELinux
| const { version } = baseImage; | ||
|
|
||
| const tag = new ImageTag({ version }); | ||
| const command = `docker build ${path} \ | ||
| const command = `docker build ${buildPath} \ |
There was a problem hiding this comment.
buildPath is implied by using it in Docker.build method. We can leave it as path instead.
There was a problem hiding this comment.
ESlint complains that "path" shadows the imported "path" module. The only reason I changed this is to make ESlint happy.
webbertakken
approved these changes
Mar 11, 2022
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
similar to game-ci/unity-builder#355
Changes
Checklist