Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add PR template #27

Merged
merged 1 commit into from
Oct 1, 2021
Merged

Add PR template #27

merged 1 commit into from
Oct 1, 2021

Conversation

ssiccha
Copy link
Collaborator

@ssiccha ssiccha commented Sep 29, 2021

Description of your PR

Checklist for the reviewer

Functions constructing generators of maximal subgroups

  • The code which computes and then stores the sizes is correct. To do this one confers to the tables referenced by the code. Tests for the group size should use RECOG.TestGroup from the recog package.
  • The test suite checks whether all constructed generators are sensible. That is it tests the generators'
    • determinants (and if applicable also the spinor norms are correct), and
    • compatibility with the correct form.

Functions assembling the list of all maximal subgroups of a certain group

The code agrees with the tables in section 8.2 of the book "The Maximal Subgroups of the Low-dimensional Finite Classical Groups".

The reviewer doesn't need to compare our results to magma's results. That's the job of the person implementing the code.

@ssiccha ssiccha mentioned this pull request Sep 29, 2021
@codecov
Copy link

codecov bot commented Sep 29, 2021

Codecov Report

Merging #27 (f6fbc33) into main (6b50fd5) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #27   +/-   ##
=======================================
  Coverage   75.12%   75.12%           
=======================================
  Files          12       12           
  Lines        1660     1660           
=======================================
  Hits         1247     1247           
  Misses        413      413           

@fingolfin fingolfin merged commit 10df79f into main Oct 1, 2021
@fingolfin fingolfin deleted the ss/pr-template branch October 1, 2021 09:40
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants