Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(pyproject): make exceptiongroup conditional for python <3.11 #527

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

actionless
Copy link
Contributor

fix(pyproject): make exceptiongroup conditional for python <3.11

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Documentation content changes

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@actionless
Copy link
Contributor Author

actionless commented Jul 2, 2024

btw it seems you don't have a pipeline which would run on PRs and run pytest, i think you can just copy your build.yml pipeline and just remove everything except for install, lint and pytest steps and change trigger to pr
2024-07-02--1719878688_1074x245_scrot

@danyeaw
Copy link
Member

danyeaw commented Jul 2, 2024

That wasn't on purpose that we aren't running tests on PRs, probably the build triggers should be something like:

on:
  push:
    branches:
      - main
    paths-ignore:
      - '*.md'
  pull_request:
    branches:
      - main
  release:
    types: [published]
  workflow_dispatch:

@danyeaw danyeaw merged commit 42e744e into gaphor:main Jul 2, 2024
4 checks passed
@actionless actionless deleted the patch-2 branch July 2, 2024 13:01
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants