Fix the Lint Errors, Re-enable Tests for PRs

[danyeaw]

In #527, we realized that lint and tests stages aren't running for PRs. This PR fixes lint errors introduced in that PR and the one before it, re-enables CI/CD for PRs, and updates dependencies.

PR Checklist

Please check if your PR fulfills the following requirements:

• I have read, and I am following the Contributor guide
• I have read and understand the Code of Conduct

PR Type

What kind of change does this PR introduce?

• Bugfix
• Feature
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Documentation content changes

What is the current behavior?

Build is failing

Issue Number: N/A

What is the new behavior?

Build is passing

Does this PR introduce a breaking change?

• Yes
• No

Other information

[amolenaar]

Looks good.

One thing I noticed on Gaphor, which uses the same build triggers, is that it's hard to build something on a fork. Normally forks do not build at all, until you create a PR.

There's no rule that says forks should build on push, maybe we should simplify and pnly build on push, not on pull_request?

[danyeaw]

Hi @amolenaar, I think if we only build on push and not on pull request, then it won't trigger for users who can't create a branch of our main repo.

If we build on both push and to a pull request, then we'll have double the builds for every push with a pull request.