Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix(e2e-tests): run gatsby-dev without --copy-all #13230

Merged
merged 11 commits into from
Apr 9, 2019
Merged

fix(e2e-tests): run gatsby-dev without --copy-all #13230

merged 11 commits into from
Apr 9, 2019

Conversation

pieh
Copy link
Contributor

@pieh pieh commented Apr 8, 2019

Description

Related Issues

@pieh pieh requested a review from a team as a code owner April 8, 2019 23:25
@pieh pieh requested a review from a team as a code owner April 9, 2019 05:39
@DSchau
Copy link
Contributor

DSchau commented Apr 9, 2019

@pieh I did validate this seems to be the fix for the e2e tests. However -- looks like the integration tests failed (for some reason) in 153dfdf.

I'll have a little time to check this out tomorrow--but I actually think we can/should merge this for the e2e tests.

@DSchau DSchau mentioned this pull request Apr 9, 2019
Merged
@sidharthachatterjee sidharthachatterjee changed the title [do-not-merge] just testing fix(e2e-tests): run gatsby-dev without --copy-all Apr 9, 2019
sidharthachatterjee
sidharthachatterjee approved these changes Apr 9, 2019
View reviewed changes
Copy link
Contributor

@sidharthachatterjee sidharthachatterjee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @pieh 👍

@sidharthachatterjee
Copy link
Contributor

@DSchau Integration tests were fixed in #13251. Merging this in.

@sidharthachatterjee sidharthachatterjee merged commit e3fc602 into master Apr 9, 2019
@sidharthachatterjee sidharthachatterjee deleted the pieh-patch-2 branch April 9, 2019 16:06
johno pushed a commit to jlengstorf/gatsby that referenced this pull request Apr 10, 2019
@pieh @johno
fix(e2e-tests): run gatsby-dev without --copy-all (gatsbyjs#13230)
519edb1
This was referenced Sep 16, 2021
Open
Open
@ajesse11x ajesse11x mentioned this pull request Jun 21, 2023
Open
@MaxMood96 MaxMood96 mentioned this pull request Jun 22, 2023
Open
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@sidharthachatterjee sidharthachatterjee sidharthachatterjee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pieh @DSchau @sidharthachatterjee