fix(gatsby-dev-cli): Persist verdaccio stuff in os.tmpdir #13251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wardpeet
reviewed
Apr 9, 2019
| @@ -12,7 +13,7 @@ const { registerCleanupTask } = require(`./cleanup-tasks`) | |||
| let VerdaccioInitPromise = null | |||
|
|
|||
| const verdaccioConfig = { | |||
| storage: path.join(__dirname, `..`, `..`, `verdaccio`, `storage`), | |||
| storage: path.join(os.tmpdir(), `verdaccio`, `storage`), | |||
There was a problem hiding this comment.
#branding 😛
Suggested change
| storage: path.join(os.tmpdir(), `verdaccio`, `storage`), | |
| storage: path.join(os.tmpdir(), `gatsby`, `verdaccio`, `storage`), |
we could also write in node_modules/.cache/verdaccio
There was a problem hiding this comment.
Want to avoid node_modules because a sudo install could break permissions and cause the same issue as https://circleci.com/gh/gatsbyjs/gatsby/104049?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link?
wardpeet
approved these changes
Apr 9, 2019
|
Published in |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It currently persists in a dir two steps back (where gatsby-dev is) and sometimes that isn't writable because of an operation previously run with
sudolike in https://circleci.com/gh/gatsbyjs/gatsby/104049?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-linkNote:
require('os').tmpdir()is good in Node.js 4 and up. So we're fine.