Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

chore(examples): use mobx v6 in using-mobx example #34351

Merged
merged 3 commits into from
Jan 3, 2022
Merged

chore(examples): use mobx v6 in using-mobx example #34351

merged 3 commits into from
Jan 3, 2022

Conversation

iChenLei
Copy link
Contributor

Description

Mobx latest version is v6 , big difference with v5. New observer pattern with makeObservable/makeAutoObservable builtin function, migration guide is here .

ChangeList:

  1. Drop Inject/Observer pattern , and using react context (hooks version)
  2. Using makeObservable rather than decorate
  3. Delete eslint relative deps (just a example, don't need so many eslint config for fast try)

Gatsby(@next) not working with eslint@v6.x.x

Example sceenshot

Documentation

Related Issues

N/A

I am mobxjs team member, so this is just a simple support for @mobxjs user commuity

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Dec 31, 2021
@LekoArts LekoArts added type: maintenance An issue or pull request describing a change that isn't a bug, feature or documentation change and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Jan 3, 2022
LekoArts
LekoArts approved these changes Jan 3, 2022
View reviewed changes
Copy link
Contributor

@LekoArts LekoArts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, really appreciate it!

@LekoArts LekoArts merged commit 3341eea into gatsbyjs:master Jan 3, 2022
@iChenLei iChenLei deleted the gatsby-example-mobx branch January 3, 2022 11:08
moonmeister added a commit to moonmeister/gatsby that referenced this pull request Jan 5, 2022
@moonmeister
Merge branch 'master' into fix/validate/warnonunknown
b656bb0 
* master: (125 commits)
  chore(release): Publish next
  fix(gatsby): createNode return promise (gatsbyjs#34399)
  chore(release): Publish next
  fix(gatsby): Wrong route resolved by findPageByPath function (gatsbyjs#34070)
  fix(deps): update typescript to v5 (major) (gatsbyjs#33786)
  chore(docs): Update processing external images guide (gatsbyjs#34388)
  chore(deps): update dependency aws-sdk to ^2.1048.0 (gatsbyjs#34365)
  chore(deps): update dependency autoprefixer to ^10.4.1 for gatsby-plugin-sass (gatsbyjs#34357)
  chore(deps): update formatting & linting (gatsbyjs#34370)
  fix(deps): update minor and patch dependencies for gatsby-source-drupal (gatsbyjs#34375)
  fix(deps): update dependency eslint-plugin-react to ^7.28.0 (gatsbyjs#34372)
  fix(deps): update dependency resolve-url-loader to ^3.1.4 for gatsby-plugin-sass (gatsbyjs#34361)
  chore(deps): update dependency typescript to ^4.5.4 (gatsbyjs#34358)
  chore(docs): Fix links to shared layout component (gatsbyjs#34330)
  chore: Fix typo (gatsbyjs#34349)
  chore(examples): use mobx v6 in using-mobx example (gatsbyjs#34351)
  chore(deps): update dependency rewire to v6 for gatsby-plugin-offline (gatsbyjs#34376)
  chore(deps): update dependency msw to ^0.36.3 for gatsby-core-utils (gatsbyjs#34367)
  chore(deps): update dependency msw to ^0.36.3 for gatsby-plugin-gatsby-cloud (gatsbyjs#34368)
  fix(deps): update dependency graphql to ^15.8.0 for gatsby-codemods (gatsbyjs#34373)
  ...
@saurabharch saurabharch mentioned this pull request Nov 27, 2023
Open
@kaocher82 kaocher82 mentioned this pull request Nov 28, 2023
Open
@ajesse11x ajesse11x mentioned this pull request Nov 29, 2023
Open
@saurabharch saurabharch mentioned this pull request Nov 30, 2023
Open
@kaocher82 kaocher82 mentioned this pull request Nov 30, 2023
Open
@ajesse11x ajesse11x mentioned this pull request Dec 1, 2023
Open
@kaocher82 kaocher82 mentioned this pull request Dec 14, 2023
Open
@ajesse11x ajesse11x mentioned this pull request Dec 15, 2023
Open
@saurabharch saurabharch mentioned this pull request Dec 15, 2023
Open
@ajesse11x ajesse11x mentioned this pull request Jan 5, 2024
Open
@saurabharch saurabharch mentioned this pull request Jan 6, 2024
Open
@kaocher82 kaocher82 mentioned this pull request Jan 6, 2024
Open
@saurabharch saurabharch mentioned this pull request May 13, 2024
Open
@ajesse11x ajesse11x mentioned this pull request May 14, 2024
Open
@kaocher82 kaocher82 mentioned this pull request May 15, 2024
Open
@Rutam21 Rutam21 mentioned this pull request Oct 9, 2024
Open
This was referenced Oct 9, 2024
Open
Open
Open
@Rutam21 Rutam21 mentioned this pull request Oct 9, 2024
Open
This was referenced Oct 10, 2024
Open
Open
@Rutam21 Rutam21 mentioned this pull request Oct 10, 2024
Open
@kaocher82 kaocher82 mentioned this pull request Oct 11, 2024
Open
This was referenced Oct 12, 2024
Open
Open
@kaocher82 kaocher82 mentioned this pull request Oct 12, 2024
Open
This was referenced Oct 12, 2024
Open
Open
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@LekoArts LekoArts LekoArts approved these changes

Assignees
No one assigned
Labels
type: maintenance An issue or pull request describing a change that isn't a bug, feature or documentation change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iChenLei @LekoArts