fix(gatsby): createNode return promise #34399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
TylerBarnes
removed
the
status: triage needed
pieh
approved these changes
Jan 4, 2022
moonmeister
added a commit
to moonmeister/gatsby
that referenced
this pull request
Jan 5, 2022
* master: (125 commits) chore(release): Publish next fix(gatsby): createNode return promise (gatsbyjs#34399) chore(release): Publish next fix(gatsby): Wrong route resolved by findPageByPath function (gatsbyjs#34070) fix(deps): update typescript to v5 (major) (gatsbyjs#33786) chore(docs): Update processing external images guide (gatsbyjs#34388) chore(deps): update dependency aws-sdk to ^2.1048.0 (gatsbyjs#34365) chore(deps): update dependency autoprefixer to ^10.4.1 for gatsby-plugin-sass (gatsbyjs#34357) chore(deps): update formatting & linting (gatsbyjs#34370) fix(deps): update minor and patch dependencies for gatsby-source-drupal (gatsbyjs#34375) fix(deps): update dependency eslint-plugin-react to ^7.28.0 (gatsbyjs#34372) fix(deps): update dependency resolve-url-loader to ^3.1.4 for gatsby-plugin-sass (gatsbyjs#34361) chore(deps): update dependency typescript to ^4.5.4 (gatsbyjs#34358) chore(docs): Fix links to shared layout component (gatsbyjs#34330) chore: Fix typo (gatsbyjs#34349) chore(examples): use mobx v6 in using-mobx example (gatsbyjs#34351) chore(deps): update dependency rewire to v6 for gatsby-plugin-offline (gatsbyjs#34376) chore(deps): update dependency msw to ^0.36.3 for gatsby-core-utils (gatsbyjs#34367) chore(deps): update dependency msw to ^0.36.3 for gatsby-plugin-gatsby-cloud (gatsbyjs#34368) fix(deps): update dependency graphql to ^15.8.0 for gatsby-codemods (gatsbyjs#34373) ...
This was referenced Oct 10, 2024
This was referenced Oct 12, 2024
This was referenced Oct 12, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
createNodeshould always return a promise but returns undefined when the node hasn't changed, this PR fixes that and adds some protective code ingatsby-source-contentfulso it doesn't always treat the return value as a promise (for previousgatsbyversions).