Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Also handle SIGTERM gracefully (backport #2747) #2757

Open
wants to merge 1 commit into
base: ign-gazebo6
Choose a base branch
from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Feb 1, 2025

🦟 Bug fix

Fixes #2738

Summary

As proposed by @azeey, in addition to SIGINT, also catch SIGTERM, which is the default signal sent when trying to stop a process externally.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

This is an automatic backport of pull request #2747 done by [Mergify](https://mergify.com).

Copy link
Contributor Author

mergify bot commented Feb 1, 2025

Cherry-pick of 13bf5be has failed:

On branch mergify/bp/ign-gazebo6/pr-2747
Your branch is up to date with 'origin/ign-gazebo6'.

You are currently cherry-picking commit 13bf5bea.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   src/cmd/cmdgazebo.rb.in

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot added the conflicts label Feb 1, 2025
@mergify mergify bot requested a review from mjcarroll as a code owner February 1, 2025 00:07
@mergify mergify bot mentioned this pull request Feb 1, 2025
8 tasks
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Feb 1, 2025
Signed-off-by: Erling Rennemo Jellum
Signed-off-by: erlingrj <erling.jellum@gmail.com>
Signed-off-by: erling <erling.jellum@gmail.com>
Co-authored-by: Addisu Z. Taddese <addisu@openrobotics.org>
Co-authored-by: Ian Chen <ichen@openrobotics.org>
(cherry picked from commit 13bf5be)
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
@azeey azeey force-pushed the mergify/bp/ign-gazebo6/pr-2747 branch from 6b89daa to 0ae5c05 Compare February 1, 2025 00:14
@azeey azeey removed the conflicts label Feb 1, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
🏯 fortress Ignition Fortress
Projects
Status: In review
Development

Successfully merging this pull request may close these issues.

3 participants