Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Final Windows fixes to complete compilation #585

Merged
merged 14 commits into from
Jan 28, 2021
Merged

Final Windows fixes to complete compilation #585

merged 14 commits into from
Jan 28, 2021

Conversation

j-rivero
Copy link
Contributor

The PR include different fixes:

  • Remove unneeded Qt support from GuiSystem
  • Visibility fixes
  • Disable TestSystem on Windows. Needs more inspection about an error with ign-plugin.

j-rivero and others added 8 commits January 15, 2021 18:45
@j-rivero
Remove invalid visibility macros
e9ba573 
Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
@j-rivero
Merge branch 'main' of github.com:ignitionrobotics/ign-gazebo into jr…
d2b5749 
…ivero/win/remove_visibility
@j-rivero
Change system to be a header only file
84f1d31 
Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
@j-rivero
Merge branch 'main' into jrivero/win/remove_visibility
3a7e8d9
@j-rivero
Merge branch 'main' into jrivero/win/remove_visibility
09d71e7
@chapulina
Merge branch 'main' into jrivero/win/remove_visibility
f077fbb
@j-rivero
Final Windows fixes to compile the software and test suite
3b23e54 
Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
@j-rivero
Merge branch 'jrivero/win/final_fixes' of github.com:ignitionrobotics…
77054d7 
…/ign-gazebo into jrivero/win/final_fixes

Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
@j-rivero j-rivero requested a review from chapulina as a code owner January 27, 2021 14:08
@github-actions github-actions bot added the 🏢 edifice Ignition Edifice label Jan 27, 2021
@j-rivero
Fix setenv to use ignition::common
eaac7ee
@j-rivero
Merge branch 'jrivero/win/final_fixes' of github.com:ignitionrobotics…
0aa3894 
…/ign-gazebo into jrivero/win/final_fixes

Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
@j-rivero
Remove duplicate
b970350 
Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
chapulina
chapulina reviewed Jan 27, 2021
View reviewed changes
@chapulina
Copy link
Contributor

Nice! I see the build passing here: Build Status 🎉

@j-rivero
Revert removal of Q_OBJECT from GuiSystem
79dff1c 
Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
@j-rivero
Remove wd4146 warning supression. Make linter happy with withspaces a…
d38c8f3 
…nd lenght

Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
@j-rivero
Copy link
Contributor Author

New test on Windows Build Status

@codecov
Copy link

codecov bot commented Jan 28, 2021 •
edited
Loading

Codecov Report

Merging #585 (991b75c) into main (cd78bd4) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #585   +/-   ##
=======================================
  Coverage   77.38%   77.38%           
=======================================
  Files         213      213           
  Lines       11954    11954           
=======================================
  Hits         9251     9251           
  Misses       2703     2703
Impacted Files Coverage Δ
include/ignition/gazebo/EventManager.hh 79.16% <ø> (ø)
include/ignition/gazebo/gui/GuiSystem.hh 0.00% <ø> (ø)
include/ignition/gazebo/gui/TmpIface.hh 0.00% <ø> (ø)
...ems/kinetic_energy_monitor/KineticEnergyMonitor.hh 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd78bd4...991b75c. Read the comment docs.

@j-rivero
Set visibility for GuiSystem
991b75c 
Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
@j-rivero
Copy link
Contributor Author

New test after fix visibility Build Status

chapulina
chapulina approved these changes Jan 28, 2021
View reviewed changes
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Feel free to merge with happy CI.

@chapulina chapulina added the Windows Windows support label Jan 28, 2021
@j-rivero j-rivero mentioned this pull request Jan 28, 2021
Merged
@j-rivero j-rivero merged commit 55ddac7 into main Jan 28, 2021
@j-rivero j-rivero deleted the jrivero/win/final_fixes branch January 28, 2021 23:32
@j-rivero j-rivero mentioned this pull request Jan 28, 2021
Open
18 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@chapulina chapulina chapulina approved these changes

Assignees
No one assigned
Labels
🏢 edifice Ignition Edifice Windows Windows support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@j-rivero @chapulina